Uploaded image for project: 'WINDUP - Red Hat Application Migration Toolkit'
  1. WINDUP - Red Hat Application Migration Toolkit
  2. WINDUP-566

Sort out the File~, Resource~, Dir~, Path~ Models.

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Won't Do
    • Icon: Major Major
    • 2.3.0.Final
    • 2.2.0.Final
    • MTA CLI
    • None

      Currently:

      • ResourceModel
      • FileModel extends ResourceModel

      New:

      • ResourceModel extends InputStreamModel
      • PathModel
      • FileModel extends PathModel, InputStreamModel
      • DirectoryModel extends PathModel

      (16:58:26) ozizka-FN: jsightler: Speaking of that: We have ResourceModel, extended by FileModel, which can also be a directory
      (16:58:29) ozizka-FN: which is not a Resource.
      (16:58:48) ozizka-FN: I think this came from Windup 0, right?
      (16:58:55) jsightler: resourcemodel itself should go away, IMO
      (16:59:11) ozizka-FN: +1, do we even use it's 2 methods?
      (16:59:18) jsightler: ozizka: Yes.
      (16:59:49) jsightler: ozizka: It came from the really early windup 2.x work. I could be wrong, but I don't think it was in windup 1.x.
      (16:59:55) jsightler: (it does predate me, though )
      (17:00:31) jsightler: Maybe have a PathModel with two subclasses? (DirectoryModel and FileModel)
      (17:00:56) LincolnThree: Yeah, I think ResourceModel was around when we inherited windup
      (17:01:00) LincolnThree: windup 2
      (17:01:05) ozizka-FN: Maybe ResourceModel should live next to FileModel,
      (17:01:18) ozizka-FN: and both should extend InputStreamModel or such.
      (17:01:37) ozizka-FN: Yes, PathModel maybe
      (17:01:37) jsightler: well, we have no other subclasses of resourcemodel
      (17:01:56) ozizka-FN: Right. The point would be to clear the api of PathModel
      (17:02:24) ozizka-FN: Or this:
      (17:02:24) ozizka-FN: * PathModel
      (17:02:24) ozizka-FN: * FileModel
      (17:02:24) ozizka-FN: * Dirmodel
      (17:02:36) ozizka-FN: Oh. Pressed enter too early
      (17:02:40) jsightler: yeah, isn't that what I just said?
      (17:03:26) ozizka-FN: * ResourceModel extends InputStreamModel
      (17:03:26) ozizka-FN: * PathModel
      (17:03:26) ozizka-FN: * FileModel extends PathModel, InputStreamModel
      (17:03:26) ozizka-FN: * Dirmodel extends PathModel
      (17:03:36) ozizka-FN: jsightler: How about that?
      (17:03:56) jsightler: Yeah, that sounds fine to me
      (17:04:05) ozizka-FN: Okay

            ozizka_jira Ondrej Zizka (Inactive)
            ozizka_jira Ondrej Zizka (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: