XMLWordPrintable

    • Icon: Story Story
    • Resolution: Obsolete
    • Icon: Critical Critical
    • None
    • 2.0.0.Alpha1
    • None
    • None

      TBH I don't like this:

              hints.add(new BlackListRegex(getID(), "((javax.naming.InitialContext)|(javax.naming.Context)).lookup", "\"<![CDATA[\"\n" + 
                  "                    + \"Ensure that the JNDI Name does not need to change for JBoss\" +\n" + 
                  "                \n" + 
                  "                \"\"*For Example:*\n" + 
                  "                \n" + 
                  "                ```java\n" + 
                  "                (ConnectionFactory)initialContext.lookup(\"weblogic.jms.ConnectionFactory\");\n" + 
                  "                ```\n" + 
                  "                \n" + 
                  "                *should become:*\n" + 
                  "                \n" + 
                  "                ```java\n" + 
                  "                (ConnectionFactory)initialContext.lookup(\"/ConnectionFactory\");\n" + 
                  "                ```\n" + 
                  "                \n" + 
                  "                \n" + 
                  "                ]]>\"", 1, Types.add(ClassCandidateType.METHOD)));
      
      

      Even in Groovy, this wouldn't look too nice.
      IMO these simple rules need to be externalized. Probably XML which it obviously is anyway. Likely not for the first release.

            lincolnthree Lincoln Baxter III (Inactive)
            ozizka_jira Ondrej Zizka (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: