Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-4878

ORB subsystem wrongly compare ModelNode property

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 10.0.0.Alpha5
    • Component/s: IIOP
    • Labels:
      None

      Description

      It seems that wrong type comparision is used in TransformUtils class [1] when model node attribute is verified if(!value.equals("off")) ...

      When looking at ModelNode code of equal method [2] it seems that the comparistion will be false in any case.

      Found out during static code analyzis check.

      [1] https://github.com/wildfly/wildfly/blob/master/legacy/jacorb/src/main/java/org/jboss/as/jacorb/TransformUtils.java#L84
      [2] https://github.com/jbossas/jboss-dmr/blob/master/src/main/java/org/jboss/dmr/ModelNode.java#L1575

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  tomekadamski Tomasz Adamski
                  Reporter:
                  ochaloup Ondrej Chaloupka
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: