Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-19147

Setting mp.health.disable-default-procedures=true in microprofile-config.properties doesn't disable default procedures

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Critical
    • None
    • 32.0.0.Beta1
    • MP Config, MP Health
    • None
    • Hide

      1. Go through what suggested by the issue where the investigation started, or
      2. Use a new test, i.e. https://github.com/wildfly/wildfly/pull/17737 - or
      3. Clone and build a WildFly snapshot
      4. Clone and build the reproducer (don't care about tests, this is a manual reproducer)
      5. Start Wildfly: ./bin/standalone.sh -c standalone-microprofile.xml
      6. Deploy the WAR built via the reproducer
      7. curl http://localhost:9990/health/ready will show the default procedures checks are in the payload.

      Show
      1. Go through what suggested by the issue where the investigation started, or 2. Use a new test, i.e. https://github.com/wildfly/wildfly/pull/17737 - or 3. Clone and build a WildFly snapshot 4. Clone and build the reproducer (don't care about tests, this is a manual reproducer) 5. Start Wildfly: ./bin/standalone.sh -c standalone-microprofile.xml 6. Deploy the WAR built via the reproducer 7. curl http://localhost:9990/health/ready will show the default procedures checks are in the payload.
    • Compatibility/Configuration, User Experience
    • Hide

      Set the mp.health.disable-default-procedures MP Config property via a system property when stating WildFly.

      Show
      Set the mp.health.disable-default-procedures MP Config property via a system property when stating WildFly.
    • ---
    • ---

    Description

      This is a follow up after investigating a user's feedback via an issue logged to the EAP MicroProfile TS project

      The MicroProfile Health specs state the following:

      To disable all default vendor procedures users can specify a MicroProfile Config configuration property mp.health.disable-default-procedures to true

      meaning that any way to provide such property is valid, and this includes the usage of a microprofile-config.properties resource in the application classpath.

      BTW WildFly MicroProfile Health documentation describes the above use case, as well:

      The MicroProfile Config property mp.health.disable-default-procedures is read at 2 different times:

      ...
      2. When an application is deployed, to determine if WildFly should add a readiness check if the deployment does not provide any. At that time, setting this property in a microprofile-config.properties file in the deployment would be taken into account. (with the usual priority rules for MicroProfile Config properties).

      It seems this behavior was changed by https://issues.redhat.com/browse/EAP7-1322 and given what above, this looks like a regression with respect to compliance with MicroProfile Health specs.

      I've been looking for an explanation, and the closest information I've found is in WFWIP-352 but actually nothing that could resolve the fact that the current implementation doesn't allow for the use cases that the specs dictate.

      BTW - the current settings in https://github.com/wildfly/wildfly/blob/main/testsuite/integration/microprofile-tck/health/src/test/resources/arquillian.xml#L13 is overriding the behavior of the Maven surefire plugin configuration, see https://github.com/wildfly/wildfly/blob/main/testsuite/integration/microprofile-tck/health/pom.xml#L95
      That being said I am logging this as Critical because a workaround exist, but feel free to let me know if I am missing anything.

      FYI mstefank, jmesnil1@redhat.com, mchoma@redhat.com

      Attachments

        Issue Links

          is cloned by

          Bug - A problem that impairs or prevents the functions of the product. JBEAP-26798 Setting mp.health.disable-default-procedures=true in microprofile-config.properties doesn't disable default procedures

          • Critical - To be worked on immediately following BLOCKER issues.
          • Open

          Activity

            People

              fburzigo Fabio Burzigotti
              fburzigo Fabio Burzigotti
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: