Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-10846

OpenTracing modules need jboss-api=private in module.xml

    Details

      Description

      The 3 modules added in https://github.com/wildfly/wildfly/pull/11454 need this in their module.xml:

          <properties>
              <property name="jboss.api" value="private"/>
          </properties>
      

      This ensures that we log a WARN if the user tries to directly use these modules as application dependencies. (Directly == via their own deployment configuration, not via our subsystem wiring them in as a dependency. See [1] for the impl.)

      These log WARNs and the setting in the file itself are important both to prevent the user making mistakes and as the formal the mechanism by which we control how we support use of the various libraries we ship in the appserver. Marking modules private, deprecated etc gives us the freedom to rework implementations without worrying about breaking unexpected uses of things.

      [1] https://github.com/wildfly/wildfly-core/blob/master/server/src/main/java/org/jboss/as/server/moduleservice/ModuleLoadService.java#L69

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                juraci.costa Juraci Paixão Kröhling
                Reporter:
                brian.stansberry Brian Stansberry
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: