Uploaded image for project: 'WildFly Core'
  1. WildFly Core
  2. WFCORE-580

Recursive read-resource with include-runtime=true assumes all runtime singleton resources will be present.

    XMLWordPrintable

Details

    • Workaround Exists
    • Hide

      I have been able to workaround this by not flagging the resource registrations for the singleton resources as being runtime resources.

      In my case I have the parent regular resource 'alias' to halt any recursive reads that are not include-runtime=true so this workaround may not suit all situations.

      Show
      I have been able to workaround this by not flagging the resource registrations for the singleton resources as being runtime resources. In my case I have the parent regular resource 'alias' to halt any recursive reads that are not include-runtime=true so this workaround may not suit all situations.

    Description

      Take the following hierarchy: -

      keystore=xxx
          alias=yyy
              certificate-chain=default
              certificate-chain=x509
      

      keystore is a regular resource with storage=configuration.
      alias is a regular resource with storage=runtime
      certificate-chain=default and certificate-chain=x509 are regular resources with storage=runtime.

      So alias represents a single alias from a Java KeyStore, this may or may not have a certificate chain and it may be a default chain or it may be an x509 chain.

      The recursive read-resource is fine with regular resources such as alias as it has to rely on the underlying resource implementation to identify the instances that actually exist.

      For the singleton resources however the following method is called: -

      org.jboss.as.controller.operations.global.GlobalOperationHandlers.getChildAddresses(OperationContext, PathAddress, ImmutableManagementResourceRegistration, Resource, String)
      

      Within this method the following check takes place: -

                      if (resource != null && resource.hasChildren(childType)) {
                          Set<String> childNames = resource.getChildrenNames(childType);
                          if (element.isWildcard()) {
                              set.addAll(childNames);
                          } else if (childNames.contains(element.getValue())) {
                              set.add(element.getValue());
                          }
      

      Up to this point all is fine, the children the resource claims are available are the only ones added.

      But further down this happens: -

                  if (!element.isWildcard()) {
                      ImmutableManagementResourceRegistration childReg = registry.getSubModel(PathAddress.pathAddress(element));
                      if (childReg != null && childReg.isRuntimeOnly()) {
                          set.add(element.getValue());
                      }
                  }
      

      So even though the resource was previously checked and missing children excluded they are now added back.

      The end result in this example is that the recursive read resource attempts to read for certificate-chain=default when it should only be reading for certificate-chain=x509 as already reported by the resource implementation.

      From a discussion in HipChat yesterday there was general agreement this behaviour seems to be wrong, however support for Proxied resources may be (incorrectly) dependent on this.

      Attachments

        Issue Links

          Activity

            People

              bstansbe@redhat.com Brian Stansberry
              darran.lofthouse@redhat.com Darran Lofthouse
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: