Uploaded image for project: 'WildFly Core'
  1. WildFly Core
  2. WFCORE-266

Deprecate the ParameterValidator constructor variants that accept allowNull and allowExpressions params

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • Major
    • None
    • None
    • Management
    • None

    Description

      Most of the ParameterValidator implementations that get passed to AttributeDefinition accept params to control whether null and expressions are allowed. These are now redundant, as AttributeDefinition wraps the provided validator with NillableOrExpressionParameterValidator, and it handles that aspect of validation based on the settings of the AD.

      So we should deprecate these constructor variants to let people know they aren't needed. Ideally shift the code as well.

      CRITICAL: before doing this, make sure the AttributeDefinition variants that support complex types properly wrap any validators that are configured for element validation. A quick look shows that ListAttributeDefinition.Builder and MapAttributeDefinition.Builder do.

      Attachments

        Activity

          People

            Unassigned Unassigned
            bstansbe@redhat.com Brian Stansberry
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: