Uploaded image for project: 'Undertow'
  1. Undertow
  2. UNDERTOW-853

SPDY: (Spdy|HTTP2)ClientConnection.sendRequest() shouldn't be synchronized

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • 2.0.0.Beta1, 1.4.7.Final
    • 1.3.25.Final
    • SPDY
    • None

    Description

      I believe commit https://github.com/undertow-io/undertow/commit/595322a869494ba03610773b2e8084da8d4a8372 should be reverted.

      The issue is that sendRequest() calls clientCallback.completed() which is on the caller side and can block for a long time, thus blocking other users/threads from calling sendRequest().

      So, I think that any synchronization must be done by the callers. Or it must be implemented different than just making this whole method synchronized.

      Attachments

        Issue Links

          is cloned by

          Bug - A problem that impairs or prevents the functions of the product. UNDERTOW-1088 SPDY: SpdyClientConnection.sendRequest() shouldn't be synchronized

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Resolved

          Bug - A problem that impairs or prevents the functions of the product. JBEAP-11837 (7.1.0) UNDERTOW-853 SPDY: (Spdy|HTTP2)ClientConnection.sendRequest() shouldn't be synchronized

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Activity

            People

              sdouglas1@redhat.com Stuart Douglas
              jsantana@redhat.com Jonh Wendell
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: