Uploaded image for project: 'ShrinkWrap'
  1. ShrinkWrap
  2. SHRINKWRAP-268

MavenDependencyResolver.loadReposFromPom and loadDependenciesFromPom methods are missleading

    Details

      Description

      Current state:

      loadReposFromPom(String file) 
      

      Loads a POM file and activates all repositories present there, moreover it loads all <dependencies> into cache so user can omit version
      in artifact specification.

      => should be renamed to loadMetadataFromPom(String file) or split to loadReposFromPom(String file), loadDependencyVersionsFromPom(String file) and aggregator loadMetadataFromPom(String file)

      loadDepedenciesFromPom(String file)
      

      Loads a POM file and adds all dependencies present there to the dependency chain. This means once the resolveXYZ() is called dependencies from POM are resolved.

      => should be renamed to includeDependenciesFromPom(String file)

      loadDependenciesFromPom(String file, MavenResolutionFilter filter)
      

      Does the same as previous, filter is not used there but during resolveXYZ()

      => should be removed

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  Silenius Samuel Santos
                  Reporter:
                  kpiwko Karel Piwko
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: