Details

    • Type: Bug Bug
    • Status: Closed Closed (View Workflow)
    • Priority: Major Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 1.0.0-alpha-12
    • Component/s: api
    • Labels:
      None
    • Similar Issues:
      Show 2 results 

      Description

      Because URLs are mutable, they must be defensively copied upon construction when creating a new UrlAsset. Else the client may switch out the URL target away from what's expected after the Asset is created.

        Activity

        Hide
        Andrew Rubinger
        added a comment -

        Good one for a community contributor. Commit alongside a test case.

        Show
        Andrew Rubinger
        added a comment - Good one for a community contributor. Commit alongside a test case.
        Hide
        Andrew Rubinger
        added a comment -

        Chris, feel free to resolve; I've pushed your commits upstream.

        Show
        Andrew Rubinger
        added a comment - Chris, feel free to resolve; I've pushed your commits upstream.
        Show
        Andrew Rubinger
        added a comment - http://github.com/shrinkwrap/shrinkwrap/commit/cb05f102f2bac188d9c28de53c4c10244a88e3d6
        Show
        Chris Wash
        added a comment - Resolving per ALR's commits: http://github.com/shrinkwrap/shrinkwrap/commit/6298c4bf364e3048949d2d030f47d4ca6a772961 http://github.com/shrinkwrap/shrinkwrap/commit/7393a433fbc869cafc65f8083343a44f78bd4b56

          People

          • Assignee:
            Chris Wash
            Reporter:
            Andrew Rubinger
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: