Uploaded image for project: 'ShrinkWrap Resolvers'
  1. ShrinkWrap Resolvers
  2. SHRINKRES-64

Fix cyclic dependency in PluginIntegrationTestCase.strictlyLoadTestDependencies

XMLWordPrintable

    • Icon: Feature Request Feature Request
    • Resolution: Done
    • Icon: Major Major
    • 2.0.0-alpha-5
    • 2.0.0-alpha-2
    • None
    • None

      This test will attempt to load current versions, which are not in place during a release:

      $ ls -l /home/alr/.m2/repository/org/jboss/shrinkwrap/resolver/shrinkwrap-resolver-api-maven/2.0.0-alpha-2/
total 12
-rw-rw-r-- 1 alr alr 164 2012-09-13 00:01 m2e-lastUpdated.properties
-rw-rw-r-- 1 alr alr 235 2012-09-13 00:01 shrinkwrap-resolver-api-maven-2.0.0-alpha-2.jar.lastUpdated
-rw-rw-r-- 1 alr alr 235 2012-09-13 00:01 shrinkwrap-resolver-api-maven-2.0.0-alpha-2.pom.lastUpdated

      For now the test will be @Ignore'd

            [SHRINKRES-64] Fix cyclic dependency in PluginIntegrationTestCase.strictlyLoadTestDependencies

            Andrew Rubinger (Inactive) added a comment -

            Upstream: https://github.com/shrinkwrap/resolver/commit/e6c57aafae2e0207c91926362efbf61977310a4a

            Andrew Rubinger (Inactive) added a comment - Upstream: https://github.com/shrinkwrap/resolver/commit/e6c57aafae2e0207c91926362efbf61977310a4a

            Karel Piwko added a comment -

            Added a pull request which should solve the issue.

            Note: Invoker plugin prepares a local repository. This needs to access internet and thus plugin tests take ~ 1 minute. If we want to reduce the time, we can move invoker execution into separate profile and execute it only in CI builds.

            Karel Piwko added a comment - Added a pull request which should solve the issue. Note: Invoker plugin prepares a local repository. This needs to access internet and thus plugin tests take ~ 1 minute. If we want to reduce the time, we can move invoker execution into separate profile and execute it only in CI builds.

            Karel Piwko added a comment - - edited

            The whole idea of having plugin tests as a part of impl-maven is wrong. It would be much better to execute test as a part of maven-invoker-plugin configuration in plugin module itself.

            Current setup break importing the project into IDE (JBDS) when no version is installed in local repository.

            Karel Piwko added a comment - - edited The whole idea of having plugin tests as a part of impl-maven is wrong. It would be much better to execute test as a part of maven-invoker-plugin configuration in plugin module itself. Current setup break importing the project into IDE (JBDS) when no version is installed in local repository.

              kpiwko Karel Piwko
              arubinge@redhat.com Andrew Rubinger (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: