Uploaded image for project: 'Satellite'
  1. Satellite
  2. SAT-16353

new wait task introduced by rh_cloud 6.0.44 is not recognized by maintain as OK to interrupt

XMLWordPrintable

    • Moderate

      +++ This bug was initially created as a clone of Bug #2164330 +++

      Description of problem:
      foreman_rh_cloud 6.0.44 introduced a new action in https://github.com/theforeman/foreman_rh_cloud/commit/8c38ff76b38f146baea755bc85d333da09d0c327: ForemanInventoryUpload::Async::DelayAction

      This is a long-running action that is there to delay "the real" task.

      However, this action is not part of the EXCLUDE_ACTIONS_FOR_RUNNING_TASKS (https://github.com/theforeman/foreman_maintain/blob/9d5f5c9315e71d08451d51fb2d41dc0f735bdfc9/definitions/features/foreman_tasks.rb#L16) list in foreman maintain, which means that when it's "running" (well, waiting, really), the "running tasks" check of foreman maintain will fail:

      1. satellite-maintain upgrade check --target-version 6.13

        Check for running tasks: [FAIL]
        There are 1 active task(s) in the system.
        Please wait for these to complete or cancel them from the Monitor tab.

      Version-Release number of selected component (if applicable):
      foreman maintain 1.2.3

      How reproducible:
      100%

      Steps to Reproduce:
      1. have a satellite system with rh_cloud 6.0.44+
      2. check on the tasks page that "Wait and Generate all reports job" is running
      3. satellite-maintain upgrade check --target-version 6.13

      Actual results:
      check fails

      Expected results:
      check suceeds as it's perfectly fine to perform maintenance when this waiting job is running

      Additional info:

      — Additional comment from on 2023-01-25T09:05:21Z

      Created redmine issue https://projects.theforeman.org/issues/35992 from this bug

      — Additional comment from on 2023-01-25T09:23:51Z

      This obviously also applies to foreman-maintain 1.1.x when doing 6.12.z upgrades or executing the check in some other context.

      — Additional comment from on 2023-01-25T12:03:15Z

      Upstream bug assigned to egolov@redhat.com

      — Additional comment from on 2023-01-25T12:03:17Z

      Upstream bug assigned to egolov@redhat.com

      — Additional comment from on 2023-01-25T20:03:23Z

      Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/35992 has been resolved.

      — Additional comment from on 2023-02-03T12:52:01Z

      VERIFIED.

      @Satellite 6.13.0 Snap 9
      rubygem-foreman_maintain-1.2.4-1.el8sat.noarch

      by the upgrade automation running 6.12.1 -> 6.13.0 upgrade

      1. foreman-maintain upgrade check --plaintext --whitelist="repositories-validate" --target-version 6.13 -y
        ...

      --------------------------------------------------------------------------------
      Check for running tasks: [OK]
      --------------------------------------------------------------------------------
      Check for old tasks in paused/stopped state: [OK]
      --------------------------------------------------------------------------------
      Check for pending tasks which are safe to delete: [OK]
      --------------------------------------------------------------------------------
      Check for tasks in planning state: [OK]
      --------------------------------------------------------------------------------
      ...

      >>> there are now no running tasks reported so the upgrade can proceed

      — Additional comment from on 2023-02-03T12:55:38Z

      There is the same issue when upgrading from 6.12.1 to 6.12.2

      Do we want to include it in 6.12.2 or 6.12.3 ?

            egolov@redhat.com Evgeni Golov
            jira-bugzilla-migration RH Bugzilla Integration
            Lukas Pramuk Lukas Pramuk
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: