-
Story
-
Resolution: Unresolved
-
Normal
-
None
-
None
Related to https://issues.redhat.com/browse/RHOAIENG-6994
Based on feedback from https://github.com/opendatahub-io/odh-dashboard/pull/2770 (https://issues.redhat.com/browse/RHOAIENG-2235)
See Slack discussion here: https://redhat-internal.slack.com/archives/C06EJG57Z0X/p1715098099690969?thread_ts=1714681683.554989&cid=C06EJG57Z0X
In the Labels section of both the Model Details and Model Version details screens (implemented by the `EditableLabelsDescriptionListGroup` component):
- Current behavior: When editing an existing label and entering an invalid value (matches an existing label or is too long), the user:
- Clicks "Edit"
- Clicks a dotted-underline label, which turns it into a text input
- Enters the invalid label text, and sees no error
- Clicks away to confirm their edit, but the edit is silently rejected with no reason given (the label goes back to its prior text) - this also triggers a PF bug, see Slack discussion here
- Desired behavior:
- Click "Edit"
- Click a dotted-underline label, which turns into a text input
- Enter the invalid label text, and see no error
- Click away to confirm the edit
- The edited label remains, but turns red. Below the labels, error text appears (styled similarly to errors on text fields) describing that "labels must not match existing labels or property keys", or that "label text can't exceed 63 characters", depending on the problem. The checkmark button to confirm edits is disabled until the offending labels are edited to resolve the validation errors.