Uploaded image for project: 'Red Hat OpenShift AI Engineering'
  1. Red Hat OpenShift AI Engineering
  2. RHOAIENG-6994

Model/Version Detail - Move "Add Label" out of edit mode

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • Dashboard
    • Testable

      Based on Feedback from https://github.com/opendatahub-io/odh-dashboard/pull/2770 (https://issues.redhat.com/browse/RHOAIENG-2235)

      See Slack discussion here: https://redhat-internal.slack.com/archives/C06EJG57Z0X/p1715087134044839?thread_ts=1714681683.554989&cid=C06EJG57Z0X

      In the Labels section of both the Model Details and Model Version details screens (implemented by the `EditableLabelsDescriptionListGroup` component):

      • Current behavior: In order to add a label, you must:
        • Click "Edit"
        • Click "Add label", which opens a modal
        • Enter the label name
        • Click Save, which adds the label to the section still being edited
        • Click the confirm checkmark to actually save the updated labels
      • Desired changes: make the "Add label" button visible only when you are NOT in edit mode, and when you submit the modal, directly save that new label to the API.

      There is an unresolved design concern that this raises: How do we handle displaying both the "Add label" control and the "X more"/"X less" control at the same time? See Slack discussion here.

      Related feedback that should be investigated and potentially addressed as part of this story: In the Add Label modal, the text input is validated as the user types and error messages appear immediately (for labels that already exist or are too long). yihwang@redhat.com suggested that instead the validation should only happen when the user tries to submit the modal. See comment on GitHub here.

            Unassigned Unassigned
            mikejturley Mike Turley
            RHOAI Dashboard
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: