Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-33076

Fix inconsistent approach for multiple `attributes.attrs` in `ha_cluster_node_options`

XMLWordPrintable

    • rhel-system-roles-1.78.1-0.1.el10
    • Normal
    • sst_system_roles
    • 13
    • 3
    • QE ack, Dev ack
    • False
    • Hide

      None

      Show
      None
    • Yes
    • Red Hat Enterprise Linux
    • System Roles Sprint 1
    • Bug Fix
    • Hide
      Cause (the user action or circumstances that trigger the bug):
      Node attributes multiple sets was handled in a manner inconsistent with the rest of the role. Instead of using only the first set and ignoring the rest, multiple sets was merged into one single set.

      Consequence (what the user experience is when the bug occurs):
       Such inconsistency can confuse a user and may complicate the possible future addition of support for multiple sets.

      Fix (what has changed to fix the bug; do not include overly technical details):
      Node attributes multiple set are handled consistently with the rest of the role. This behavior is also described more explicitly in README.md.

      Result (what happens now that the patch is applied):
      Node attributes multiple set are handled consistently with the rest of the role.
      Show
      Cause (the user action or circumstances that trigger the bug): Node attributes multiple sets was handled in a manner inconsistent with the rest of the role. Instead of using only the first set and ignoring the rest, multiple sets was merged into one single set. Consequence (what the user experience is when the bug occurs):  Such inconsistency can confuse a user and may complicate the possible future addition of support for multiple sets. Fix (what has changed to fix the bug; do not include overly technical details): Node attributes multiple set are handled consistently with the rest of the role. This behavior is also described more explicitly in README.md. Result (what happens now that the patch is applied): Node attributes multiple set are handled consistently with the rest of the role.
    • Proposed

      In HA Cluster configuration, there is a common structure that allows multiple sets of key-value pairs. However, `pcs`, which is used by the `system_role_ha_cluster` for creating configuration, does support only a single set of the key-value pairs.

      In the `system_role_ha_cluster` appeared two different approaches to deal with it:

      • use only the first set and ignore the rest (in the most cases)
      • merge multiple sets into one single set (in the case of `ha_cluster_node_options.attributes.attrs`)

      Such inconsistency can confuse a user and may complicate the possible future addition of support for multiple sets. So, node attributes should be modified to behave like the other cases. Also in README should be the behavior explicitly mentioned.

            rmeggins@redhat.com Richard Megginson
            idevat@redhat.com Ivan Devát
            Ivan Devát Ivan Devát
            David Jez David Jez
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated: