Uploaded image for project: 'PicketLink'
  1. PicketLink
  2. PLINK-225

Fix thread safety issues with File and LDAP stores

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: PLINK_2.5.0.Beta6
    • Fix Version/s: PLINK_2.5.2.FInal
    • Component/s: IDM
    • Labels:
      None

      Description

      As posted by Stuart Douglas on the security-dev forums:

      Hi,

      I have just been looking over Picketlink and I think I have spotted a couple of thread safety issues:

      • File Data Store is not thread safe

      It looks like there are quite a few problems here, but the biggest is that FileDataStore does not seem to use any sync, so multiple threads can be attempting to write out the database at the same time. Also threads can be modifying the database in memory at the same time it is being written out, so it is possible to write the DB in an inconsistent state.

      Also when the file is written out it is written out directly over the old file, which greatly increases the chance of file corruption (rather than writing a tmp file and then moving it over the existing one). The also means that any sort of error (such as a non-serializable attribute) will corrupt the store and make it unreadable.

      • LDAPIdentityStore is using SimpleDateFormat in a non-threadsafe manner

      LDAPIdentityStore uses a static SimpleDateFormat, which is not thread safe. Not only that but this date format is modified before it is used in LDAPIdentityStore#parseLDAPDate, so if multiple threads are parsing dates with different timezone formats at the same time anything could happen.

      Stuart

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                pcraveiro Pedro Igor Silva
                Reporter:
                shane.bryzak Shane Bryzak
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: