Uploaded image for project: 'OptaPlanner'
  1. OptaPlanner
  2. PLANNER-2240

Use KieHelper in ScoreDirectorFactoryFactory

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Done
    • Icon: Major Major
    • 8.1.0.Final
    • None
    • optaplanner-core
    • None
    • 2020 Week 46-48 (from Nov 9)
    • 2
    • Undefined
    • NEW
    • NEW

      With KieHelper we can reduce the amount of code there.

      Reqs:

      • Use PropertySpecificOption.ALLOWED
      • Any (normal) error in the DRL must come out (= wrapped) as a IlllegalStateException which has an error message that contains "scoreDrl", for example "The scoreDrl has errors.
        • Ideally, if the DRL has multiple errors, they are all reported there.
        • Compare an error in the DRL before and after this change: is the the DRL line still avaiable?

      Optional:

      • I think errors and warnings are currently double logged, so these changes might fix that.
      • Warnings should still show up in drools logging WARN, if they don't show up in optaplanner warn log any more
        • This is an acceptable regression
      • By avoiding kmodel.toXML(), we can probably exclude xstream and kie-soup-xstream from the dependency tree

            lpetrovi@redhat.com Lukáš Petrovický (Inactive)
            gdesmet@redhat.com Geoffrey De Smet (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: