Uploaded image for project: 'OpenShift Java Client'
  1. OpenShift Java Client
  2. OSJC-50

openshift-java-client: client should not hard-code user-agent if you're usign keys

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Done
    • Major
    • 2.1.0
    • None
    • None
    • None

    Description

      There is also very weird code in the UrlConnectionHttpClientBuilder which holds user-agent building logic. IMHO this logic should be in the rest service, not in the builder since the user-agent should get built correctly even if you create the client directly or use the builder:

      UrlConnectionHttpClientBuilder
      	public IHttpClient client() {
		if (authKey != null && authKey.trim().length() > 0) {
			if (userAgent == null) {
				userAgent = "OpenShift";
			} else if (!userAgent.startsWith("OpenShift")) {
				userAgent = "OpenShift-" + userAgent;
			}
		}
		return new UrlConnectionHttpClient(username, password, userAgent,
				sslChecks, requestMediaType, acceptedMediaType, version,
				authKey, authIV);
	}

      Attachments

        Issue Links

          duplicates

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) OSJC-73 openshift-java-client: improve how userAgent is passed to UrlConnectionClient

          • Minor - To be worked after urgent, high, and medium priorities are resolved. This term is chosen when the severity of the issue is low, or the complexity or effort to correct it may be higher, relatively speaking. For low priority issues, known workarounds exist or are not needed due to the trivial effort needed to address the issue.
          • Closed
          relates to

          Bug - A problem that impairs or prevents the functions of the product. OSJC-16 openshift-java-client: make sure useragent is sent

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Activity

            People

              adietish@redhat.com André Dietisheim
              adietish@redhat.com André Dietisheim
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: