Uploaded image for project: 'OpenShift Dev Console'
  1. OpenShift Dev Console
  2. ODC-6238

Environment page: Invalid form state should disable the save button

XMLWordPrintable

    • ODC Sprint 206
    • Low

      Description of problem:

      When the user makes changes to a BuildConfig (or Pod) with the environment page or tab the form should disable the save button when the form is not filled out correctly.

      For example if the user fills our a value without a name.

      Prerequisites (if any, like setup, operators/versions):

      None

      Steps to Reproduce

      1. Open developer perspective and navigate to Builds
      2. Click "Create BuildConfig" button
      3. Create the BuildConfig without additional changes
      4. Switch to the "Environment" tab
      5. Enter an value without a name and press save.

      Actual results:

      1. The name field is not marked as required.
      2. The save button is clickable, the form was submitted to the backend and then shows an error like this:
        Error "Required value" for field "spec.strategy.sourceStrategy.env[0].name".
        

      Expected results:

      1. The name column should be marked as required with a red asterisk.
      2. The save button should be disabled as long as the form is invalid. The fields which are invalid should show an error so that the user can understand which field is required.

      Reproducibility (Always/Intermittent/Only Once):

      Always

      Build Details:

      4.9

      Additional info:

      This is an follow up on ODC-6206 which changed this behavior. Issue was mentioned by abhindas

      Earlier fields without a name was just dropped. The new version doesn't drop the inserted user data and shows this error.

            yvakil@redhat.com Yohaan Vakil (Inactive)
            cjerolim Christoph Jerolimov
            Gajanan More Gajanan More (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: