Uploaded image for project: 'OpenShift Container Platform (OCP) Strategy'
  1. OpenShift Container Platform (OCP) Strategy
  2. OCPSTRAT-1334

[Hive] Propagate machinepool labels from machinepool to machine

XMLWordPrintable

    • False
    • Hide

      None

      Show
      None
    • False
    • 100% To Do, 0% In Progress, 0% Done
    • 0
    • 0

      Feature Overview (aka. Goal Summary)  

      An elevator pitch (value statement) that describes the Feature in a clear, concise way.  Complete during New status.

      Propagate machinepool labels from machinepool to machine using Hive.

      Goals (aka. expected user outcomes)

      The observable functionality that the user now has as a result of receiving this feature. Include the anticipated primary user type/persona and which existing features, if any, will be expanded. Complete during New status.

       
      As a user, I have a use-case where I have 80 machinepools that I want to capture under a single machine-api MachineHealthCheck CustomResource. MachineHealthChecks only select machines based on labels, so it would be nice if I could set a consistent label on all the machines in these 80 machinepools.

      Today, Hive machinepools have a way to propagate labels from machinepools --> nodes https://github.com/openshift/hive/blob/227c25916da4c0b1bb3255b7c030d2ccf36384a0/pkg/controller/machinepool/machinepool_controller.go#L618:L623 but in order to propagate the labels down to machines the labels also need to go into .spec.template.metadata.labels of the generated machineset.

      Requirements (aka. Acceptance Criteria):

      A list of specific needs or objectives that a feature must deliver in order to be considered complete.  Be sure to include nonfunctional requirements such as security, reliability, performance, maintainability, scalability, usability, etc.  Initial completion during Refinement status.

      Machinepool labels from machinepool are propagated to machine using Hive for OSD/ROSA.

       

      Anyone reviewing this Feature needs to know which deployment configurations that the Feature will apply to (or not) once it's been completed.  Describe specific needs (or indicate N/A) for each of the following deployment scenarios. For specific configurations that are out-of-scope for a given release, ensure you provide the OCPSTRAT (for the future to be supported configuration) as well.

      Deployment considerations List applicable specific needs (N/A = not applicable)
      Self-managed, managed, or both Managed
      Classic (standalone cluster) Classic
      Hosted control planes TBD
      Multi node, Compact (three node), or Single node (SNO), or all All
      Connected / Restricted Network All
      Architectures, e.g. x86_x64, ARM (aarch64), IBM Power (ppc64le), and IBM Z (s390x) All supported architectures on OSD and ROSA
      Operator compatibility N/A
      Backport needed (list applicable versions) N/A
      UI need (e.g. OpenShift Console, dynamic plugin, OCM) N/A
      Other (please specify) N/A

      Use Cases (Optional):

      Include use case diagrams, main success scenarios, alternative flow scenarios.  Initial completion during Refinement status.

      <your text here>

      Questions to Answer (Optional):

      Include a list of refinement / architectural questions that may need to be answered before coding can begin.  Initial completion during Refinement status.

      <your text here>

      Out of Scope

      High-level list of items that are out of scope.  Initial completion during Refinement status.

      <your text here>

      Background

      Provide any additional context is needed to frame the feature.  Initial completion during Refinement status.

      <your text here>

      Customer Considerations

      Provide any additional customer-specific considerations that must be made when designing and delivering the Feature.  Initial completion during Refinement status.

      <your text here>

      Documentation Considerations

      Provide information that needs to be considered and planned so that documentation will meet customer needs.  If the feature extends existing functionality, provide a link to its current documentation. Initial completion during Refinement status.

      <your text here>

      Interoperability Considerations

      Which other projects, including ROSA/OSD/ARO, and versions in our portfolio does this feature impact?  What interoperability test scenarios should be factored by the layered products?  Initial completion during Refinement status.

      <your text here>

            julim Ju Lim
            julim Ju Lim
            Antoni Segura Puimedon, David Huynh, Eric Fried, Maria Del Mar Alonso, Michael Shen
            Xiaoli Tian Xiaoli Tian
            Jeana Routh Jeana Routh
            Eric Fried Eric Fried
            Eric Fried Eric Fried
            Ju Lim Ju Lim
            Eric Rich Eric Rich
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: