Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-33154

Incorrect use of go wait groups

XMLWordPrintable

    • Low
    • No
    • False
    • Hide

      None

      Show
      None

      Description of problem:

      Looking at the code snippet at line 198, the wg.Add(1) should be moved closer to the function it is waiting for (line 226).

      Having another function in between that could exit could leave the controller in a state where it will be waiting for a defer that can never occur, meaning that the controller will never terminate. 

      Version-Release number of selected component (if applicable):

      Found on the master branch while cross-referencing errors/logs for a cluster.

      How reproducible:

      Not reproducible.

      Additional info:

      Not required: resolution has already found

      • For OCPBUGS in which the issue has been identified, label with “sbr-triaged”
        • Done

            rhn-support-dsquirre David Squirrell
            rhn-support-dsquirre David Squirrell
            Anurag Saxena Anurag Saxena
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated: