Uploaded image for project: 'ModeShape'
  1. ModeShape
  2. MODE-859

The ModeShape 'with-dependencies' JAR files contain JAR files but should be unpacked

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Critical
    • 2.2.0.Final
    • 2.1.0.Final
    • None
    • None
    • Documentation (Ref Guide, User Guide, etc.)
    • Low

    Description

      We created additional artifacts (using the 'with-dependencies' classifier) for all of the ModeShape extensions and the 'modeshape-jcr' module that included all dependencies, making it easier for people that want to use ModeShape but don't use Maven. For example, the 'modeshape-jcr-

      {version}with-dependencies.jar' contains all of the classes from that module and all of its dependencies. Each of the sequencer, connector, mime-type detector, and classloader extension modules also created the '-with-dependencies.jar' artifacts that were similar, except they do not include any of the JARs already included in 'modeshape-jcr{version}

      -with-dependencies.jar' (since the extensions are expected to be used with the ModeShape JCR JAR file).

      The problem is that these "-with-dependency" JAR files contain the JARs of the dependencies, and so they have to be extracted in order to be used. We should instead follow the standard "jar-with-dependencies" assembly descriptor and make these JAR files contain the unpacked JARs, so the "-with-dependency" JARs can simply be placed on the classpath and used as-is.

      Additionally, we should conform to the standard "jar-with-dependency" classifier (rather than the "with-dependency"). We could use the standard "jar-with-dependencies" assembly descriptor (which includes *all* dependencies), but then resulting JARs for our extension modules (e.g., sequencers, connectors, etc.) would each contain copies of ModeShape's core modules (e.g., "modeshape-graph", "modeshape-common", and their dependencies). We don't want to do this, so we still need to have custom assembly descriptors - they just need to be named correctly.

      Attachments

        Activity

          People

            rhauch Randall Hauch (Inactive)
            rhauch Randall Hauch (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: