Uploaded image for project: 'ModeShape'
  1. ModeShape
  2. MODE-1910

Update InfinispanBinaryStore to use getBestBufferSize to calculate buffer size

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Trivial
    • 3.3.0.Final
    • 3.3.0.Final
    • Storage
    • None

    Description

      Here's some code in the InfinispanBinaryStore:

      int bufferSize = 8192;
      if (bufferSize > fileLength) bufferSize = 4096;
      if (bufferSize > fileLength) bufferSize = 2096;

      https://github.com/ModeShape/modeshape/blob/master/modeshape-jcr/src/main/java/org/modeshape/jcr/value/binary/infinispan/InfinispanBinaryStore.java#L221

      I assume 2096 should be 2048.

      After talking with Kosch on IRC, we decided to replace this with a call to bestBufferSize from the AbstractBinaryStore instead.

      Attachments

        Activity

          People

            rhauch Randall Hauch (Inactive)
            cbeer_jira Chris Beer (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: