[MODE-1473] Second property is ignored in org.modeshape.jcr.query.qom.JcrQueryObjectModelFactory.equiJoinCondition(String, String, String, String) - JBoss Issue Tracker

Details

Forum Reference:
https://community.jboss.org/thread/199049
Git Pull Request:
https://github.com/ModeShape/modeshape/pull/369, https://github.com/ModeShape/modeshape/pull/370

There is a bug in the method org.modeshape.jcr.query.qom.JcrQueryObjectModelFactory.equiJoinCondition(String, String, String, String):

public EquiJoinCondition equiJoinCondition( String selector1Name,

                                            String property1Name,

                                            String selector2Name,

                                            String property2Name ) {

    CheckArg.isNotNull(selector1Name, "selector1Name");

    CheckArg.isNotNull(property1Name, "property1Name");

    CheckArg.isNotNull(selector2Name, "selector2Name");

    CheckArg.isNotNull(selector2Name, "selector2Name");

    return new JcrEquiJoinCondition(selectorName(selector1Name), property1Name, selectorName(selector2Name), selector2Name);

where selector2Name is used as the 4th parameter to the JcrEquiJoinCondition constructor, but should be property2Name.

relates to

MODE-1468 JQOM queries are not converted to SQL2

Hide

Permalink

Randall Hauch added a comment - 02/May/12 10:09 AM

This is a simple fix. Mind tackling it?

Show

Randall Hauch added a comment - 02/May/12 10:09 AM This is a simple fix. Mind tackling it?

Hide

Permalink

Horia Chiorean added a comment - 02/May/12 10:49 AM

Fixed the parameter handling. Added pull requests for 2.x and master, all tests pass.

Show

Horia Chiorean added a comment - 02/May/12 10:49 AM Fixed the parameter handling. Added pull requests for 2.x and master, all tests pass.

Hide

Permalink

Randall Hauch added a comment - 02/May/12 11:31 AM

Merged both pull requests: one into '2.x' and the other into 'master'.

Show

Randall Hauch added a comment - 02/May/12 11:31 AM Merged both pull requests: one into '2.x' and the other into 'master'.