Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: 2.8.1.Final
-
Fix Version/s: 2.8.2.Final, 3.0.0.Alpha4
-
Component/s: Query
-
Labels:None
-
Forum Reference:
-
Similar Issues:
Description
There is a bug in the method org.modeshape.jcr.query.qom.JcrQueryObjectModelFactory.equiJoinCondition(String, String, String, String):
public EquiJoinCondition equiJoinCondition( String selector1Name, |
String property1Name,
|
String selector2Name,
|
String property2Name ) {
|
CheckArg.isNotNull(selector1Name, "selector1Name"); |
CheckArg.isNotNull(property1Name, "property1Name"); |
CheckArg.isNotNull(selector2Name, "selector2Name"); |
CheckArg.isNotNull(selector2Name, "selector2Name"); |
return new JcrEquiJoinCondition(selectorName(selector1Name), property1Name, selectorName(selector2Name), selector2Name); |
}
|
where selector2Name is used as the 4th parameter to the JcrEquiJoinCondition constructor, but should be property2Name.
Gliffy Diagrams
Issue Links
- relates to
-
MODE-1468
JQOM queries are not converted to SQL2
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Fixed the parameter handling. Added pull requests for 2.x and master, all tests pass.
Show
Horia Chiorean
added a comment - Fixed the parameter handling. Added pull requests for 2.x and master, all tests pass.
Horia Chiorean
added a comment - Fixed the parameter handling. Added pull requests for 2.x and master, all tests pass. Merged both pull requests: one into '2.x' and the other into 'master'.
Show
Randall Hauch
added a comment - Merged both pull requests: one into '2.x' and the other into 'master'.
Randall Hauch
added a comment - Merged both pull requests: one into '2.x' and the other into 'master'. 
This is a simple fix. Mind tackling it?