ModeShape
  1. ModeShape
  2. MODE-1473

Second property is ignored in org.modeshape.jcr.query.qom.JcrQueryObjectModelFactory.equiJoinCondition(String, String, String, String)

    Details

    • Similar Issues:
      Show 10 results 

      Description

      There is a bug in the method org.modeshape.jcr.query.qom.JcrQueryObjectModelFactory.equiJoinCondition(String, String, String, String):

      public EquiJoinCondition equiJoinCondition( String selector1Name,
                                                  String property1Name,
                                                  String selector2Name,
                                                  String property2Name ) {
          CheckArg.isNotNull(selector1Name, "selector1Name");
          CheckArg.isNotNull(property1Name, "property1Name");
          CheckArg.isNotNull(selector2Name, "selector2Name");
          CheckArg.isNotNull(selector2Name, "selector2Name");
          return new JcrEquiJoinCondition(selectorName(selector1Name), property1Name, selectorName(selector2Name), selector2Name);
      }
      

      where selector2Name is used as the 4th parameter to the JcrEquiJoinCondition constructor, but should be property2Name.

        Issue Links

          Activity

          Hide
          Randall Hauch
          added a comment -

          This is a simple fix. Mind tackling it?

          Show
          Randall Hauch
          added a comment - This is a simple fix. Mind tackling it?
          Hide
          Horia Chiorean
          added a comment -

          Fixed the parameter handling. Added pull requests for 2.x and master, all tests pass.

          Show
          Horia Chiorean
          added a comment - Fixed the parameter handling. Added pull requests for 2.x and master, all tests pass.
          Hide
          Randall Hauch
          added a comment -

          Merged both pull requests: one into '2.x' and the other into 'master'.

          Show
          Randall Hauch
          added a comment - Merged both pull requests: one into '2.x' and the other into 'master'.

            People

            • Assignee:
              Horia Chiorean
              Reporter:
              Dmitri Voronov
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: