Uploaded image for project: 'ModeShape'
  1. ModeShape
  2. MODE-1001

Clean up FileSystemConnector behavior for matching files

XMLWordPrintable

    • Icon: Feature Request Feature Request
    • Resolution: Done
    • Icon: Minor Minor
    • 2.4.0.Final, 2.2.1.GA
    • None
    • Storage
    • None
    • Documentation (Ref Guide, User Guide, etc.), Release Notes, Compatibility/Configuration

      The current file system connector has two options, mutually exclusive: exclusionPattern and filenameFilter. FilenameFilter supports either a class or an instance. ExclusionPattern supports a string to be used like a regex. These options are mutually exclusive - setting one unsets the other and vice versa (little scary IMHO, since it's all up to order of invocation to determine which is actually used). I think that to work best, we should continue to support exclusionPattern and filenameFilter, however when setting the exclusion pattern it actually sets the filenameFilter to a filename filter using the pattern in the exclusionPattern. This turns exclusionPattern in to a psuedo property - it may be called, but there will not be an underlying value. Similarly, we should provide a new property inclusionPattern that behaves the same way. If both of these properties are set, the filename filter will do proper inclusion and exclusion strategy.

      To do this, a new class InclusionExclusionFilenameFilter will be added to the project that has setters for both inclusion and exclusion patterns. Logic will need to be added to the getFilenameFilter to handle this class appropriately.

            meetoblivion_jira John Ament (Inactive)
            meetoblivion_jira John Ament (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: