Uploaded image for project: 'JGroups'
  1. JGroups
  2. JGRP-1639

Locking: lock name with negative hashCode() throws out of bound exception

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • 3.3.2, 3.4
    • None
    • None

    Description

      [Steve Luebbe]

      Based on the code in the org.jgroups.protocols.Locking it tries to calculate an index based on the lock name (code in next 2 lines):

          protected Lock _getLock(String lock_name) {
        int index=lock_name != null? lock_name.hashCode() % locks.length : 0;
        return locks[index];
    }

      When debugging I can see that:

      lock_name = dpa_project
      lock_name.hashCode() = -1316662737
      locks.length = 10

      SOLUTION: use Math.abs() on the hash code

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem that impairs or prevents the functions of the product. JGRP-1634 LockingService.tryLock() randomly hangs, and tryLock(timeout) does not acquire the lock even though it is free to be taken

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Resolved

          Bug - A problem that impairs or prevents the functions of the product. JGRP-1636 java.lang.ArrayIndexOutOfBoundsException when trying to accure lock

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Resolved

          Activity

            People

              rhn-engineering-bban Bela Ban
              rhn-engineering-bban Bela Ban
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: