JBRULES
  1. JBRULES
  2. JBRULES-2809

Exists/Not Nodes have ordering problem for repetitive updates on same facts

    Details

    • Similar Issues:
      Show 10 results 

      Description

      Seeing this with CurriculumCourseApp. Reproduced with trunk and with 5.1.1.

      Writing a testcase for regression testing.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Geoffrey De Smet added a comment - - edited

            Long term TTD testcase proof: CurriculumCourseSmokeTest.solveComp01() but there's a temp proof in the patch that's more isolated (see below)

            Show
            Geoffrey De Smet added a comment - - edited Long term TTD testcase proof: CurriculumCourseSmokeTest.solveComp01() but there's a temp proof in the patch that's more isolated (see below)
            Hide
            Geoffrey De Smet added a comment -

            Reproducing patch attached.
            Patch it, and run CurriculumCourseScoreRulesTest it will fail.
            I 've narrowed testComp01_jbrules2809.xml down so there as few facts as possible in the working memory.

            Don't apply this patch to trunk, the test CurriculumCourseSmokeTest (currently @Ignore) tests this too (but isn't narrowed down at all)

            Show
            Geoffrey De Smet added a comment - Reproducing patch attached. Patch it, and run CurriculumCourseScoreRulesTest it will fail. I 've narrowed testComp01_jbrules2809.xml down so there as few facts as possible in the working memory. Don't apply this patch to trunk, the test CurriculumCourseSmokeTest (currently @Ignore) tests this too (but isn't narrowed down at all)
            Hide
            Geoffrey De Smet added a comment -

            Tried on latest master and 5.1.x of today and reproduced them.

            Show
            Geoffrey De Smet added a comment - Tried on latest master and 5.1.x of today and reproduced them.
            Hide
            Geoffrey De Smet added a comment -

            Previous testcase patch was wrong.
            This testcase patch is correct and removes planner code.

            Show
            Geoffrey De Smet added a comment - Previous testcase patch was wrong. This testcase patch is correct and removes planner code.
            Hide
            Geoffrey De Smet added a comment - - edited

            Changing priority to blocker: 7 out of 9 planner examples suffer from it.
            Enable enviromnentMode TRACE in planner to detect the corruptions.
            In most examples it seriously hurts the quality of the solution of the planner.

            This is a serious REGRESSION since Drools 5.0 (but there's still a net gain due to the performance improvement of true modify in 5.1).

            Show
            Geoffrey De Smet added a comment - - edited Changing priority to blocker: 7 out of 9 planner examples suffer from it. Enable enviromnentMode TRACE in planner to detect the corruptions. In most examples it seriously hurts the quality of the solution of the planner. This is a serious REGRESSION since Drools 5.0 (but there's still a net gain due to the performance improvement of true modify in 5.1).
            Hide
            Geoffrey De Smet added a comment - - edited

            mark fixed test 2.
            ====
            But this might have raised a new issue: part 3: see patch 3.1 which proves it.

            Show
            Geoffrey De Smet added a comment - - edited mark fixed test 2. ==== But this might have raised a new issue: part 3: see patch 3.1 which proves it.
            Hide
            Geoffrey De Smet added a comment -

            mark fixed part 3.1.

            Found a new one: see attachment part 4

            Show
            Geoffrey De Smet added a comment - mark fixed part 3.1. Found a new one: see attachment part 4
            Hide
            Geoffrey De Smet added a comment -

            Mark fixed part 4 too.

            Looks like everything is fixed.
            Planner's examination, pas, curriculumcourse, nurserostering and travelingtournament examples in environmentMode TRACE do no longer found any memory corruptions.

            Show
            Geoffrey De Smet added a comment - Mark fixed part 4 too. Looks like everything is fixed. Planner's examination, pas, curriculumcourse, nurserostering and travelingtournament examples in environmentMode TRACE do no longer found any memory corruptions.

              People

              • Assignee:
                Mark Proctor
                Reporter:
                Geoffrey De Smet
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development