JBRULES
  1. JBRULES
  2. JBRULES-2301

Get rid of System.out.println statement

    Details

    • Type: Quality Risk Quality Risk
    • Status: Resolved (View Workflow)
    • Priority: Minor Minor
    • Resolution: Done
    • Affects Version/s: 5.1.0.M1
    • Fix Version/s: 5.5.0.Beta1
    • Component/s: All
    • Labels:
      None
    • Estimated Difficulty:
      Low
    • Similar Issues:
      Show 10 results 

      Description

      System.out.println statement is currently used in 280 project files. I propose to replace them with logger.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Christoph Gritschenberger added a comment -

            This is really annoying since it pollutes the osgi-console (using karaf)

            Show
            Christoph Gritschenberger added a comment - This is really annoying since it pollutes the osgi-console (using karaf)
            Hide
            Christoph Czurda added a comment -

            I fixed this for the whole drools-compiler and the Activators of drools-core, droolsjbpm-knowledge and jbpm-flow-builder.
            Please see my pull requests at: https://github.com/droolsjbpm/drools/pull/58 , https://github.com/droolsjbpm/droolsjbpm-knowledge/pull/12 and https://github.com/droolsjbpm/jbpm/pull/30

            Show
            Christoph Czurda added a comment - I fixed this for the whole drools-compiler and the Activators of drools-core, droolsjbpm-knowledge and jbpm-flow-builder. Please see my pull requests at: https://github.com/droolsjbpm/drools/pull/58 , https://github.com/droolsjbpm/droolsjbpm-knowledge/pull/12 and https://github.com/droolsjbpm/jbpm/pull/30
            Hide
            Christoph Czurda added a comment -

            Any news on this? Should the sysouts be removed alltogether as was done for jbpm?

            Show
            Christoph Czurda added a comment - Any news on this? Should the sysouts be removed alltogether as was done for jbpm?
            Hide
            Andreas Pieber added a comment -

            Hey guys, any news on this one? The sys.out statements still polute our OSGi console and are kind of confusing to our customers. It would be really great if this one could be fixed!

            Show
            Andreas Pieber added a comment - Hey guys, any news on this one? The sys.out statements still polute our OSGi console and are kind of confusing to our customers. It would be really great if this one could be fixed!
            Hide
            Geoffrey De Smet added a comment -

            Fixed, except for the System.err stuff in the ANTLR generated files that - in theory - is never called.

            http://github.com/droolsjbpm/drools/compare/e330de4...81e9bfd

            Show
            Geoffrey De Smet added a comment - Fixed, except for the System.err stuff in the ANTLR generated files that - in theory - is never called. http://github.com/droolsjbpm/drools/compare/e330de4...81e9bfd
            Hide
            Andreas Pieber added a comment -

            finally, and after almost 3 years of work all syso had been removed... impressive...

            Independently, thanks a ton guys that this finally had been resolved!

            Show
            Andreas Pieber added a comment - finally, and after almost 3 years of work all syso had been removed... impressive... Independently, thanks a ton guys that this finally had been resolved!

              People

              • Assignee:
                Geoffrey De Smet
                Reporter:
                Juraj Tomasov
              • Votes:
                2 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development