Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-26086

SSP server does not send error codes for bad requests

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Do
    • Icon: Major Major
    • 4.30.x
    • 4.6.0.AM3
    • None

      Sending a request the server does not like produces no response, it is simply logged on the server side and the client is not notified of what happened. Something like a code 400 would be appreciated.

      For example, initiating a connection with no content-length header simply logs the following on the server side, but the client is stuck waiting.

      java.lang.IllegalStateException: Missing header Content-Length in input "GET / HTTP/1.1
      Sec-WebSocket-Version: 13
      Sec-WebSocket-Key: 4vrbTo0+BlSk5wK7si6SWQ==
      Connection: Upgrade
      Upgrade: websocket
      Sec-WebSocket-Extensions: permessage-deflate; client_max_window_bits
      Host: localhost:27511
      
      "
      	at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.listen(StreamMessageProducer.java:89)
      	at org.eclipse.lsp4j.jsonrpc.json.ConcurrentMessageProcessor.run(ConcurrentMessageProcessor.java:95)
      	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
      	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
      	at java.lang.Thread.run(Thread.java:748)

      This is most likely a 'feature' of lsp4j, thoughts?

            rob.stryker Rob Stryker (Inactive)
            jrichter@redhat.com Jan Richter
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: