Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-22870

fetch-sources-from-manifests may reference a plugin whose SHA is older than another plugin in the repo

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 4.4.1.AM3
    • Fix Version/s: 4.4.2.AM2
    • Component/s: build
    • Labels:
      None

      Description

      The fetch-sources-from-manifests mojo uses the Eclipse-SourceReferences entry in a given plugin's MANIFEST.MF to see which SHA should be used to to produce the source zip for that repo.

      For example, Forge uses the org.jboss.tools.forge.core plugin, which has its latest SHA = 6beb7d3b3218e8b02d0497d38915574f9eaf8c1f

      However, the latest commit in the master branch of jbosstools-forge is 3 commits later, daa126d38f8ff59c4244a6315dfc5c88b80abf5b.

      So, when the jboss tools aggregate fires, it sees a disconnect between the source SHA and the latest SHA in github, and the build is red:

      [INFO] --- repository-utils:0.25.1-SNAPSHOT:fetch-sources-from-manifests (fetch-sources) @ org.jboss.tools.site.core ---
      [INFO] Downloaded:  jbosstools-aerogear_0ac8df2dbdd2a7d4d8255cec88f845bf5f7700e6_sources.zip (494.9 k)
      [INFO] Downloaded:  jbosstools-arquillian_96ac958b446e3655e8c8843e3de67b9e21c5294b_sources.zip (448.3 k)
      [INFO] Downloaded:  jbosstools-base_6ec1deba2610a94a14d160a7b54ae4f708c40044_sources.zip (23.6 M)
      [INFO] Downloaded:  jbosstools-browsersim_019a66b4cef24d489c5bad2c0324477e32871222_sources.zip (3.2 M)
      [INFO] Downloaded:  jbosstools-central_1ed0291d1f76f6327ee046ea8962e3798861d25e_sources.zip (8.2 M)
      [INFO] Downloaded:  jbosstools-forge_6beb7d3b3218e8b02d0497d38915574f9eaf8c1f_sources.zip (430.3 k)
      [INFO] Downloaded:  jbosstools-freemarker_ad694bbeacc1be6ed7ea6511edfba9e7df6ba386_sources.zip (368.2 k)
      [INFO] Downloaded:  jbosstools-hibernate_3e9fb83570c5c7c521f92d3f05c77b67355477d0_sources.zip (26.9 M)
      [INFO] Downloaded:  jbosstools-javaee_a3e97d0495026b043ff151ac65412ba64bcfc1ff_sources.zip (46.2 M)
      [INFO] Downloaded:  jbosstools-jst_4ddeac73b11f40e39bc3593231de500abde0396e_sources.zip (6.3 M)
      [INFO] Downloaded:  jbosstools-livereload_8aacb494f4221b8022db63908e6f27a8b770714b_sources.zip (261.1 k)
      [INFO] Downloaded:  jbosstools-openshift_810571f6aff04eb4a4b0b986e9ad4c0f16796b25_sources.zip (1.8 M)
      [INFO] Downloaded:  jbosstools-portlet_4eec888e7045ab1413934670cbdcdf7a11447b52_sources.zip (1.2 M)
      [INFO] Downloaded:  jbosstools-server_5de0eae6e90b3a58f63ec62432c050e61f5313ce_sources.zip (34.5 M)
      [INFO] Downloaded:  jbosstools-vpe_bd95b9c63a5b05bec19afe483f8224cf07c8aef8_sources.zip (3.5 M)
      [INFO] Downloaded:  jbosstools-webservices_c8cfc7db7c501ca0cc0290d6079c33ada7cd73c9_sources.zip (15.4 M)
      [INFO] Downloaded:  jbosstools-xulrunner_2edce933f7d64efbb4d7a5b16be8dadae8de766e_sources.zip (46.5 M)
      [INFO] ------------------------------------------------------------------------
      [INFO] BUILD FAILURE
      [INFO] ------------------------------------------------------------------------
      [INFO] Total time: 05:44 min
      [INFO] Finished at: 2016-08-02T06:58:56-04:00
      [INFO] Final Memory: 139M/1923M
      [INFO] ------------------------------------------------------------------------
      [ERROR] Failed to execute goal org.jboss.tools.tycho-plugins:repository-utils:0.25.1-SNAPSHOT:fetch-sources-from-manifests (fetch-sources) on project org.jboss.tools.site.core: Problem occurred checking upstream buildinfo.json files!
      [ERROR] /mnt/hudson_workspace/workspace/jbosstools-build-sites.aggregate.site_master/sources/aggregate/site/target/buildinfo/buildinfo_jbosstools-forge.json
      [ERROR] contains daa126d38f8ff59c4244a6315dfc5c88b80abf5b, but upstream jbosstools-forge project's MANIFEST.MF has Eclipse-SourceReferences
      [ERROR] commitId 6beb7d3b3218e8b02d0497d38915574f9eaf8c1f.
      [ERROR] If you have locally built projects which are aggregated here,
      [ERROR] ensure they are built from the latest SHA from HEAD, not a local topic branch.
      [ERROR] Or, use -DskipCheckSHAs=true to bypass this check.
      

      So, we could simply skip this check, but really, we need to determine WHICH SHA is the latest/correct one for the build... if we just pick one plugin, we might pick one that doesn't get updated very often and the build will break again.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  nickboldt Nick Boldt
                  Reporter:
                  nickboldt Nick Boldt
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: