Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-22764

OpenShift 3 doesn't compile with latest changes in Docker tooling

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 4.4.1.AM2
    • 4.4.1.AM1
    • openshift
    • None
    • devex #117 July 2016
    • 1

      Some temporary hack (https://github.com/jbosstools/jbosstools-openshift/commit/189fd3dfc0060866bdb5a4197502cc3f0e3cce87?diff=unified#diff-7c0e23e79b061ce0d1f81e959bf4751dR70) no longer compiles against the latest docker tooling (in master) code:

      // FIXME: needs to catch DockerCertificateException until
      // https://bugs.eclipse.org/bugs/show_bug.cgi?id=495249 is fixed
      catch (DockerException | InterruptedException | DockerCertificateException e) {
      	return new Status(IStatus.ERROR, OpenShiftUIActivator.PLUGIN_ID,
      			"Failed to push the selected Docker image into OpenShift registry", e);
      }
      

      com.spotify.docker.client.DockerCertificateException is no longer thrown by the Docker API so the catch block fails to compile.

      We can fix the compilation problem with Neon.1 while still maintaining Neon.0 compatibility with a different, yet fugly, trick.

            fbricon@redhat.com Fred Bricon
            fbricon@redhat.com Fred Bricon
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: