Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-22308

Generate p2diff together when generating TP site

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Done
    • Icon: Major Major
    • 4.4.0.Alpha2
    • 4.3.1.Final
    • target-platform
    • None

      In the "multiple2repo" profile, add the necessary build steps to always generate the p2diff report.

            [JBIDE-22308] Generate p2diff together when generating TP site

            Jan Richter added a comment -

            Do you guys want me to verify this? I don't really know where exactly to look and it feels more like a change in the internal process than in the product.
            If verification is needed, just point me to the change, otherwise just close this please

            Jan Richter added a comment - Do you guys want me to verify this? I don't really know where exactly to look and it feels more like a change in the internal process than in the product. If verification is needed, just point me to the change, otherwise just close this please

            Nick Boldt added a comment -

            OK, I've opened a new one instead. JBIDE-22448

            Hooray for paperwork!

            Nick Boldt added a comment - OK, I've opened a new one instead. JBIDE-22448 Hooray for paperwork!

            Mickael Istria added a comment -

            Please avoid reopening issue since it messes up tracking. The work item for this issue was done as part of previous sprint, what you report is actually a new blocker issue for the current sprint, it needs to be tracked separately.

            Mickael Istria added a comment - Please avoid reopening issue since it messes up tracking. The work item for this issue was done as part of previous sprint, what you report is actually a new blocker issue for the current sprint, it needs to be tracked separately.

            Nick Boldt added a comment -

            Reopening because we need an extra check here to ensure that if the reference TP doesn't exist, p2diff generation is NOT done (or empty files are created).

            Scenario where creation of a p2diff is bad:

            • first build for a new TP version (eg., when moving from Alpha1-SNAPSHOT to Alpha3-SNAPSHOT)

            Nick Boldt added a comment - Reopening because we need an extra check here to ensure that if the reference TP doesn't exist, p2diff generation is NOT done (or empty files are created). Scenario where creation of a p2diff is bad: first build for a new TP version (eg., when moving from Alpha1-SNAPSHOT to Alpha3-SNAPSHOT)

            Mickael Istria added a comment -

            Suggested PR for target-platforms: https://github.com/jbosstools/jbosstools-target-platforms/pull/208

            Mickael Istria added a comment - Suggested PR for target-platforms: https://github.com/jbosstools/jbosstools-target-platforms/pull/208

            Mickael Istria added a comment -

            Suggested PR for p2diff: https://github.com/irbull/p2diff/pull/11

            Mickael Istria added a comment - Suggested PR for p2diff: https://github.com/irbull/p2diff/pull/11

              mistria@redhat.com Mickael Istria
              mistria@redhat.com Mickael Istria
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: