Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-18903

Refactor implementations of ITagLibRecognizer

XMLWordPrintable

      Currently, implementations of methods

      boolean shouldBeLoaded(ITagLibrary lib, ELContext context);
      boolean isUsed(IHTMLLibraryVersion version, ELContext context);
      boolean isUsed(IHTMLLibraryVersion version, IFile file);
      

      do the same but it is not evident since the code is not reused properly.
      For now, it is better to implement two new methods through the old one and in future change only for subclasses that would really by some reasons need different implementation.

      Second commit should change interface methods as follows

      boolean ITagLibRecognizer.isUsed(ELContext context);
      boolean ITagLibRecognizer.isUsed(IFile file);
      IHTMLLibraryVersion ITagLibVersionRecognizer.getVersion(ELContext context);
      

            scabanovich Viacheslav Kabanovich (Inactive)
            scabanovich Viacheslav Kabanovich (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: