-
Enhancement
-
Resolution: Done
-
Major
-
4.2.0.Alpha1
-
None
-
https://github.com/jbosstools/jbosstools-build/pull/107, https://github.com/jbosstools/jbosstools-aerogear/pull/27, https://github.com/jbosstools/jbosstools-arquillian/pull/57, https://github.com/jbosstools/jbosstools-central/pull/214, https://github.com/jbosstools/jbosstools-birt/pull/19, https://github.com/jbosstools/jbosstools-forge/pull/71, https://github.com/jbosstools/jbosstools-freemarker/pull/15, https://github.com/jbosstools/jbosstools-hibernate/pull/37, https://github.com/jbosstools/jbosstools-javaee/pull/201, https://github.com/jbosstools/jbosstools-jst/pull/272, https://github.com/jbosstools/jbosstools-livereload/pull/75, https://github.com/jbosstools/jbosstools-openshift/pull/363, https://github.com/jbosstools/jbosstools-portlet/pull/27, https://github.com/jbosstools/jbosstools-vpe/pull/218, https://github.com/jbosstools/jbosstools-webservices/pull/119
Currently every feature's pom.xml includes the same code, which is code-duplication issue.
<plugin> <groupId>org.eclipse.tycho.extras</groupId> <artifactId>tycho-source-feature-plugin</artifactId> <version>${tychoExtrasVersion}</version> <executions> <execution> <id>source-feature</id> <phase>package</phase> <goals> <goal>source-feature</goal> </goals> </execution> </executions> </plugin> <plugin> <groupId>org.eclipse.tycho</groupId> <artifactId>tycho-p2-plugin</artifactId> <version>${tychoVersion}</version> <executions> <execution> <id>attached-p2-metadata</id> <phase>package</phase> <goals> <goal>p2-metadata</goal> </goals> </execution> </executions> </plugin>
It should be included into pluginManagement section of parent/pom.xml instead and that would reduce code duplication to
<plugin> <groupId>org.eclipse.tycho.extras</groupId> <artifactId>tycho-source-feature-plugin</artifactId> </plugin> <plugin> <groupId>org.eclipse.tycho</groupId> <artifactId>tycho-p2-plugin</artifactId> </plugin>
in every feture's pom.xml file.
More over code above could be moved to to features/pom.xml as
<build> <plugins> <plugin> <groupId>org.eclipse.tycho.extras</groupId> <artifactId>tycho-source-feature-plugin</artifactId> </plugin> <plugin> <groupId>org.eclipse.tycho</groupId> <artifactId>tycho-p2-plugin</artifactId> </plugin> </plugins> </build>
that would let keep pom.xml for every feature even cleaner.