Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-11130

Better handle unavailable downloadable runtimes

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 3.3.0.Beta3
    • 3.3.0.M5
    • project-examples
    • None
    • Hide

      The bug can be reproduced using the attached project example site (It uses a fake download id = org.jboss.tools.runtime.core.as.901) :

      • Save attached aerogear.xml to disk
      • Window > Preferences > JBoss Tools > Project Examples
      • Click the Add button, and select local aerogear.xml
      • Close and reopen JBoss Central
      • Click on the Aerogear project in Project Examples > JBoss Maven Archetypes
      • Click on the server/runtime line
        ASSERT The "Download and Install..." button is greyed out
        FAILS A NPE occurs
      Show
      The bug can be reproduced using the attached project example site (It uses a fake download id = org.jboss.tools.runtime.core.as.901) : Save attached aerogear.xml to disk Window > Preferences > JBoss Tools > Project Examples Click the Add button, and select local aerogear.xml Close and reopen JBoss Central Click on the Aerogear project in Project Examples > JBoss Maven Archetypes Click on the server/runtime line ASSERT The "Download and Install..." button is greyed out FAILS A NPE occurs

      If we define a project example for JBoss Central having :

      <fix type="wtpruntime">
          <property name="allowed-types">org.jboss.ide.eclipse.as.runtime.71, org.jboss.ide.eclipse.as.runtime.eap.60</property>
          <property name="description">This project example requires JBoss AS 7.1 or EAP 6 </property>
          <property name="downloadId">org.jboss.tools.runtime.core.as.710</property>
      </fix>
      

      and update the project-example-X.xml for JBoss Tools M5, a NPE will occur when the runtime requirement is selected :

      	at org.jboss.tools.project.examples.wizard.NewProjectExamplesRequirementsPage$3.selectionChanged(NewProjectExamplesRequirementsPage.java:324)
      	at org.eclipse.jface.viewers.Viewer$2.run(Viewer.java:164)
      	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
      	at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:49)
      	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)
      	at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java:162)
      	at org.eclipse.jface.viewers.StructuredViewer.updateSelection(StructuredViewer.java:2188)
      	at org.eclipse.jface.viewers.StructuredViewer.handleSelect(StructuredViewer.java:1211)
      	at org.eclipse.jface.viewers.StructuredViewer$4.widgetSelected(StructuredViewer.java:1241)
      	at org.eclipse.jface.util.OpenStrategy.fireSelectionEvent(OpenStrategy.java:239)
      	at org.eclipse.jface.util.OpenStrategy.access$4(OpenStrategy.java:233)
      	at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:403)
      	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
      	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
      	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4165)
      	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3754)
      	at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
      	at org.eclipse.jface.window.Window.open(Window.java:801)
      	at org.jboss.tools.central.editors.GettingStartedPage$17.linkActivated(GettingStartedPage.java:986)
      	at org.eclipse.ui.forms.widgets.FormText.activateLink(FormText.java:1552)
      	at org.eclipse.ui.forms.widgets.FormText.handleMouseClick(FormText.java:1355)
      	at org.eclipse.ui.forms.widgets.FormText.access$16(FormText.java:1326)
      	at org.eclipse.ui.forms.widgets.FormText$6.mouseUp(FormText.java:448)
      	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:219)
      	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
      	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
      	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4165)
      	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3754)
      	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)
      	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)
      	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)
      	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)
      	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
      	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)
      	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
      	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
      	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
      	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
      	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
      	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
      	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      	at java.lang.reflect.Method.invoke(Method.java:597)
      	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
      	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
      	at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
      	at org.eclipse.equinox.launcher.Main.main(Main.java:1386)
      

      More generally, unavailable downloads shouldn't prevent users from using the project example (Download and install button should be grayed out).

            snjeza_jira Snjezana Peco (Inactive)
            fbricon@redhat.com Fred Bricon
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: