Uploaded image for project: 'Application Server 3  4  5 and 6'
  1. Application Server 3 4 5 and 6
  2. JBAS-8381

Widen the range of raw SNMP types permitted by RequestHandlerImpl

XMLWordPrintable

    • Icon: Patch Patch
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • JBossAS-5.1.0.GA
    • SNMP adapter
    • None
    • Low

      RequestHandlerImpl.getValue() for includes logic for determining how to express a JMX attribute in terms of an SNMP type. It supports Long, Integer, and String, as well as values of the raw SnmpTimeTicks and SnmpObjectId types.

      I think this should be widened, by removing the check for SnmpTimeTicks and SnmpObjectId, and replacing it with a single check for the SnmpSyntax interface. This would allow beans to return the full range of SNMP types. Also, an explicit check for null should be performed, and represented by the SnmpNull type.

      Note that setValueFor() is already more restrictive than getValueFor(), so we wouldn't be introducing any new asymmetry.

      Patch for RequestHandlerImpl.java to follow.

            dandread1@redhat.com Dimitrios Andreadis
            skaffman Kenny MacLeod (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: