Uploaded image for project: 'Infinispan'
  1. Infinispan
  2. ISPN-2420

Increment the topology id when a node leaves the cache

This issue belongs to an archived project. You can view it, but you can't modify it. Learn more

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Done
    • Icon: Major Major
    • 5.2.0.Final
    • 5.2.0.Final
    • State Transfer
    • None

      We currently increment the topology id only when we "rebalance" the consistent hash (i.e. we add new owners). This allows us to to do some optimizations after a leave, like not forwarding commands (because there are no new owners).

      Unfortunately, it is not very intuitive, because it doesn't match how JGroups works, so it can cause bugs like ISPN-2417.

      Additionally, it turns out there are many places where we care that a node left, so the code is more complex to handle this (e.g. TransactionTable.useStrictTopologyIdComparison()), or it is more slow for the common case when there is no leaver (e.g. LocalTransaction.getCommitNodes()).

          1.
          		 Optimise the call to LocalTransaction.getCommitNodes Sub-task Closed Major Adrian Nistor (Inactive)

            [ISPN-2420] Increment the topology id when a node leaves the cache

            Dan Berindei (Inactive) added a comment -

            The pull request doesn't address the possible optimizations/clarifications that can be made now that all ConsistentHash updates increment the topology id. Perhaps we should keep this issue open.

            Dan Berindei (Inactive) added a comment - The pull request doesn't address the possible optimizations/clarifications that can be made now that all ConsistentHash updates increment the topology id. Perhaps we should keep this issue open.

              dberinde@redhat.com Dan Berindei (Inactive)
              dberinde@redhat.com Dan Berindei (Inactive)
              Archiver:
              rhn-support-adongare Amol Dongare

                Created:
                Updated:
                Resolved:
                Archived: