Infinispan
  1. Infinispan
  2. ISPN-2081

Transaction leak caused by reordering between prepare and rollback

    Details

    • Bugzilla Update:
      Perform
    • Similar Issues:
      Show 10 results 

      Description

      There's no ordering between the prepare and commit/rollback messages, as the later are sent OOB.
      With this in mind, the following transaction leak might happen:
      Tx1 send prepare on nodes

      {A,B}

      1. the message reaches A and timeouts but hasn't yet been processed on B
      2. The transaction originator reacts immediately to the timeout received from A without waiting the response from B and sends a rollback request
      3. The rollback request is processed on A and B
      4. The initial prepare is then processed on B

      At this point we have an orphan transaction prepare on B.
      Whilst this is not causing any inconsistencies, it keeps keys locked indefinitely and is a memory leak.

      The solution would be to wait at 2 for all the prepare messages before sending the rollback.
      Attached is a unit test to reproduce the issue.

      Related mailing list thread: http://infinispan.markmail.org/search/#query:%20list%3Aorg.jboss.lists.infinispan-dev+page:1+mid:xgnmtee56jpqifs6+state:results

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            RH Bugzilla Integration added a comment -

            mark yarborough <myarboro@redhat.com> made a comment on bug 841889

            ttarrant will add jira links as appropriate.

            Show
            RH Bugzilla Integration added a comment - mark yarborough <myarboro@redhat.com> made a comment on bug 841889 ttarrant will add jira links as appropriate.
            Hide
            RH Bugzilla Integration added a comment -

            Tristan Tarrant <ttarrant@redhat.com> changed the Status of bug 841889 from NEW to ASSIGNED

            Show
            RH Bugzilla Integration added a comment - Tristan Tarrant <ttarrant@redhat.com> changed the Status of bug 841889 from NEW to ASSIGNED
            Hide
            RH Bugzilla Integration added a comment -

            Tristan Tarrant <ttarrant@redhat.com> changed the Status of bug 841889 from ASSIGNED to ON_QA

            Show
            RH Bugzilla Integration added a comment - Tristan Tarrant <ttarrant@redhat.com> changed the Status of bug 841889 from ASSIGNED to ON_QA
            Hide
            RH Bugzilla Integration added a comment -

            Anna Manukyan <amanukya@redhat.com> changed the Status of bug 841889 from ON_QA to VERIFIED

            Show
            RH Bugzilla Integration added a comment - Anna Manukyan <amanukya@redhat.com> changed the Status of bug 841889 from ON_QA to VERIFIED
            Hide
            RH Bugzilla Integration added a comment -

            Anna Manukyan <amanukya@redhat.com> made a comment on bug 841889

            I've verified that all added tests are in place. They run on all environments and succeeded.

            Show
            RH Bugzilla Integration added a comment - Anna Manukyan <amanukya@redhat.com> made a comment on bug 841889 I've verified that all added tests are in place. They run on all environments and succeeded.

              People

              • Assignee:
                Mircea Markus
                Reporter:
                Mircea Markus
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development