Uploaded image for project: 'Hawkular'
  1. Hawkular
  2. HAWKULAR-290

remove unneeded dependencySet in assembly.xml

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Done
    • Icon: Minor Minor
    • 1.0.0.Alpha1-done-items
    • None
    • Build
    • None

      See the assembly.xml that builds kettle, specifically this:

      https://github.com/hawkular/hawkular/blob/master/dist/assembly.xml#L138L153

      Which is this dependencySet:

          <!--
          hawkular-accounts is separated from the others because we need a stable name to the war, without the
          version number. This is because we use the Keycloak's "secure-deployment" to configure the integration, and that
          requires the war name.
          -->
          <dependencySet>
            <outputDirectory>${wildfly.dist.zip.root.dir}/modules/org/hawkular/nest/main/deployments</outputDirectory>
            <useProjectArtifact>false</useProjectArtifact>
            <includes>
              <include>org.hawkular.accounts:hawkular-accounts:war</include>
            </includes>
            <outputFileNameMapping>hawkular-accounts.war</outputFileNameMapping>
            <unpack>false</unpack>
            <fileMode>0644</fileMode>
            <directoryMode>0755</directoryMode>
          </dependencySet>
      

      We no longer need this since we already strip versions out of all the other deployments. See this line which is further up:

            <outputFileNameMapping>${artifact.artifactId}${dashClassifier?}.${artifact.extension}</outputFileNameMapping>
      

      in the dependencySet that has the comment "<!-- all component deployments that go in the nest's internal modules directory -->"

            ppalaga Peter Palaga
            jmazzitelli John Mazzitelli
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: