• Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • fuse-7.0
    • fuse-7.0
    • Karaf
    • None
    • % %
    • Fuse 7.0 Sprint 27

      We need an alignment of swagger versions - I think Grzegorz is going to look at this after the karaf 4.2.0 release. I'm commenting out the karaf-cxf-rest fabric8-quickstart out of the build in the meantime. Need to add that back in once the alignment is complete.

      [WARNING] The requested profile "release" could not be activated because it does not exist.
      [ERROR] Failed to execute goal org.apache.karaf.tooling:karaf-maven-plugin:4.2.0.fuse-000183:assembly (karaf-assembly) on project karaf-cxf-rest: Unable to build assembly: Unable to resolve root: missing requirement [root] osgi.identity; osgi.identity=io.swagger.jaxrs; type=osgi.bundle; version="[1.5.12,1.5.12]"; resolution:=mandatory [caused by: Unable to resolve io.swagger.jaxrs/1.5.12: missing requirement [io.swagger.jaxrs/1.5.12] osgi.wiring.package; filter:="(&(osgi.wiring.package=com.google.common.base)(version>=18.0.0)(!(version>=19.0.0)))"] -> [Help 1]
      org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.karaf.tooling:karaf-maven-plugin:4.2.0.fuse-000183:assembly (karaf-assembly) on project karaf-cxf-rest: Unable to build assembly
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
      at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
      at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
      at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
      at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
      at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
      at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
      at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
      at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
      at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
      at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      at java.lang.reflect.Method.invoke(Method.java:498)
      at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
      at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
      at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
      at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
      Caused by: org.apache.maven.plugin.MojoExecutionException: Unable to build assembly
      at org.apache.karaf.tooling.AssemblyMojo.execute(AssemblyMojo.java:448)
      at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
      ... 20 more
      Caused by: org.osgi.service.resolver.ResolutionException: Unable to resolve root: missing requirement [root] osgi.identity; osgi.identity=io.swagger.jaxrs; type=osgi.bundle; version="[1.5.12,1.5.12]"; resolution:=mandatory [caused by: Unable to resolve io.swagger.jaxrs/1.5.12: missing requirement [io.swagger.jaxrs/1.5.12] osgi.wiring.package; filter:="(&(osgi.wiring.package=com.google.common.base)(version>=18.0.0)(!(version>=19.0.0)))"]
      at org.apache.felix.resolver.ResolutionError.toException(ResolutionError.java:42)
      at org.apache.felix.resolver.ResolverImpl.doResolve(ResolverImpl.java:391)
      at org.apache.felix.resolver.ResolverImpl.resolve(ResolverImpl.java:377)
      at org.apache.felix.resolver.ResolverImpl.resolve(ResolverImpl.java:349)
      at org.apache.karaf.features.internal.region.SubsystemResolver.resolve(SubsystemResolver.java:248)
      at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:385)
      at org.apache.karaf.features.internal.service.Deployer.deployFully(Deployer.java:327)
      at org.apache.karaf.profile.assembly.Builder.resolve(Builder.java:1990)
      at org.apache.karaf.profile.assembly.Builder.startupStage(Builder.java:1801)
      at org.apache.karaf.profile.assembly.Builder.doGenerateAssembly(Builder.java:1103)
      at org.apache.karaf.profile.assembly.Builder.generateAssembly(Builder.java:848)
      at org.apache.karaf.tooling.AssemblyMojo.doExecute(AssemblyMojo.java:543)
      at org.apache.karaf.tooling.AssemblyMojo.execute(AssemblyMojo.java:444)
      ... 22 more
      [ERROR]
      [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [ERROR]
      [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
      [Pipeline] }
      [Pipeline] // configFileProvider
      [Pipeline] sh

            [ENTESB-7766] Swagger version alignment

            Andrej Vano added a comment -

            Looks OK with 191-redhat-1

            Andrej Vano added a comment - Looks OK with 191-redhat-1

            We're finally using 1.5.18.fuse70-1-redhat-1

            Grzegorz Grzybek added a comment - We're finally using 1.5.18.fuse70-1-redhat-1

            Grzegorz Grzybek added a comment - Fixed here in https://github.com/jboss-fuse/fuse-karaf/commits/master

            Grzegorz Grzybek added a comment - PR for fuse-karaf: https://github.com/jboss-fuse/fuse-karaf/pull/111

            Grzegorz Grzybek added a comment - Fixed here in https://github.com/jboss-fuse/camel/commits/master

            Grzegorz Grzybek added a comment - Fixed here in https://github.com/jboss-fuse/cxf/commits/3.1.11.redhat-7-0-0-stable

            Grzegorz Grzybek added a comment - - edited

            tcunning@redhat.com, rhn-support-jsherman, janstey@redhat.com, acosenti, yfang@redhat.com I prepared two branches:

            Both branches are created out of official v1.5.18 tag.

            Fuse 7 seems to work/resolve fine:

            karaf@root()> la -l|grep swagger
             27 │ Active   │  35 │ 1.5.18.fuse70-1        │ mvn:io.swagger/swagger-annotations/1.5.18.fuse70-1
             28 │ Active   │  35 │ 1.5.18.fuse70-1        │ mvn:io.swagger/swagger-core/1.5.18.fuse70-1
             29 │ Active   │  35 │ 1.5.18.fuse70-1        │ mvn:io.swagger/swagger-jaxrs/1.5.18.fuse70-1
             30 │ Active   │  35 │ 1.5.18.fuse70-1        │ mvn:io.swagger/swagger-models/1.5.18.fuse70-1
            104 │ Active   │  40 │ 3.1.11.fuse-000198     │ mvn:org.apache.cxf/cxf-rt-rs-service-description-swagger/3.1.11.fuse-000198
            
            karaf@root()> feature:info camel-swagger-java
            Feature camel-swagger-java 2.21.0.fuse-000054
            Feature has no configuration
            Feature has no configuration files
            Feature depends on:
              http 0.0.0
              camel-core 2.21.0.fuse-000054
            Feature contains followed bundles:
              mvn:org.apache.servicemix.specs/org.apache.servicemix.specs.jsr311-api-1.1.1/2.9.0
              mvn:com.fasterxml.jackson.core/jackson-core/2.8.9
              mvn:com.fasterxml.jackson.core/jackson-databind/2.8.9
              mvn:com.fasterxml.jackson.core/jackson-annotations/2.8.9
              mvn:com.fasterxml.jackson.dataformat/jackson-dataformat-xml/2.8.9
              mvn:com.fasterxml.jackson.dataformat/jackson-dataformat-yaml/2.8.9
              mvn:com.fasterxml.jackson.module/jackson-module-jaxb-annotations/2.8.9
              mvn:com.fasterxml.jackson.jaxrs/jackson-jaxrs-base/2.8.9
              mvn:com.fasterxml.jackson.jaxrs/jackson-jaxrs-json-provider/2.8.9
              mvn:org.yaml/snakeyaml/1.19 (overriden from mvn:org.yaml/snakeyaml/1.19)
              mvn:javax.validation/validation-api/1.1.0.Final
              mvn:org.apache.commons/commons-lang3/3.7 (overriden from mvn:org.apache.commons/commons-lang3/3.7)
              mvn:com.google.guava/guava/20.0.0.redhat-1 (overriden from mvn:com.google.guava/guava/20.0)
              mvn:io.swagger/swagger-core/1.5.18.fuse70-1 (overriden from mvn:io.swagger/swagger-core/1.5.17)
              mvn:io.swagger/swagger-annotations/1.5.18.fuse70-1 (overriden from mvn:io.swagger/swagger-annotations/1.5.17)
              mvn:io.swagger/swagger-models/1.5.18.fuse70-1 (overriden from mvn:io.swagger/swagger-models/1.5.17)
              mvn:io.swagger/swagger-jaxrs/1.5.18.fuse70-1 (overriden from mvn:io.swagger/swagger-jaxrs/1.5.17)
              wrap:mvn:io.swagger/swagger-parser/1.0.33
              mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.reflections/0.9.11_1 (overriden from mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.reflections/0.9.11_1)
              mvn:org.apache.camel/camel-swagger-java/2.21.0.fuse-000054
            Feature has no conditionals.
            

            What do you think?

            Grzegorz Grzybek added a comment - - edited tcunning@redhat.com , rhn-support-jsherman , janstey@redhat.com , acosenti , yfang@redhat.com I prepared two branches: https://github.com/jboss-fuse/swagger-core/commits/v1.5.18-fuse-63x - aligned to guava 18, jackson 2.6 and reflections 0.9.10 https://github.com/jboss-fuse/swagger-core/commits/v1.5.18-fuse-70x - aligned to jackson 2.8 (and using unchanged deps on guava 20 and reflections 0.9.11) Both branches are created out of official v1.5.18 tag. Fuse 7 seems to work/resolve fine: karaf@root()> la -l|grep swagger 27 │ Active │ 35 │ 1.5.18.fuse70-1 │ mvn:io.swagger/swagger-annotations/1.5.18.fuse70-1 28 │ Active │ 35 │ 1.5.18.fuse70-1 │ mvn:io.swagger/swagger-core/1.5.18.fuse70-1 29 │ Active │ 35 │ 1.5.18.fuse70-1 │ mvn:io.swagger/swagger-jaxrs/1.5.18.fuse70-1 30 │ Active │ 35 │ 1.5.18.fuse70-1 │ mvn:io.swagger/swagger-models/1.5.18.fuse70-1 104 │ Active │ 40 │ 3.1.11.fuse-000198 │ mvn:org.apache.cxf/cxf-rt-rs-service-description-swagger/3.1.11.fuse-000198 karaf@root()> feature:info camel-swagger-java Feature camel-swagger-java 2.21.0.fuse-000054 Feature has no configuration Feature has no configuration files Feature depends on: http 0.0.0 camel-core 2.21.0.fuse-000054 Feature contains followed bundles: mvn:org.apache.servicemix.specs/org.apache.servicemix.specs.jsr311-api-1.1.1/2.9.0 mvn:com.fasterxml.jackson.core/jackson-core/2.8.9 mvn:com.fasterxml.jackson.core/jackson-databind/2.8.9 mvn:com.fasterxml.jackson.core/jackson-annotations/2.8.9 mvn:com.fasterxml.jackson.dataformat/jackson-dataformat-xml/2.8.9 mvn:com.fasterxml.jackson.dataformat/jackson-dataformat-yaml/2.8.9 mvn:com.fasterxml.jackson.module/jackson-module-jaxb-annotations/2.8.9 mvn:com.fasterxml.jackson.jaxrs/jackson-jaxrs-base/2.8.9 mvn:com.fasterxml.jackson.jaxrs/jackson-jaxrs-json-provider/2.8.9 mvn:org.yaml/snakeyaml/1.19 (overriden from mvn:org.yaml/snakeyaml/1.19) mvn:javax.validation/validation-api/1.1.0.Final mvn:org.apache.commons/commons-lang3/3.7 (overriden from mvn:org.apache.commons/commons-lang3/3.7) mvn:com.google.guava/guava/20.0.0.redhat-1 (overriden from mvn:com.google.guava/guava/20.0) mvn:io.swagger/swagger-core/1.5.18.fuse70-1 (overriden from mvn:io.swagger/swagger-core/1.5.17) mvn:io.swagger/swagger-annotations/1.5.18.fuse70-1 (overriden from mvn:io.swagger/swagger-annotations/1.5.17) mvn:io.swagger/swagger-models/1.5.18.fuse70-1 (overriden from mvn:io.swagger/swagger-models/1.5.17) mvn:io.swagger/swagger-jaxrs/1.5.18.fuse70-1 (overriden from mvn:io.swagger/swagger-jaxrs/1.5.17) wrap:mvn:io.swagger/swagger-parser/1.0.33 mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.reflections/0.9.11_1 (overriden from mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.reflections/0.9.11_1) mvn:org.apache.camel/camel-swagger-java/2.21.0.fuse-000054 Feature has no conditionals. What do you think?

            Is this done?

            Aileen Cunningham added a comment - Is this done?

            yfang@redhat.com, acosenti, tcunning@redhat.com I was looking at CXF commit history (upstream) and found this in parent/pom.xml:

            <cxf.swagger2.version>1.5.17</cxf.swagger2.version><!-- updating to 1.5.18 will cause systest failures -->
            

            I think we should stick with swagger 1.5.17, which, even if switched dependency from guava 18 to 20 without telling anyone in OSGi land (we fortunately handled the upgrade), somehow works well.

            acosenti what's in 1.5.18 that can't be done with 1.5.17? This entire Jackson upgrade is (IMO) too problematic.

            Grzegorz Grzybek added a comment - yfang@redhat.com , acosenti , tcunning@redhat.com I was looking at CXF commit history (upstream) and found this in parent/pom.xml : <cxf.swagger2.version> 1.5.17 </cxf.swagger2.version> <!-- updating to 1.5.18 will cause systest failures --> I think we should stick with swagger 1.5.17, which, even if switched dependency from guava 18 to 20 without telling anyone in OSGi land (we fortunately handled the upgrade), somehow works well. acosenti what's in 1.5.18 that can't be done with 1.5.17? This entire Jackson upgrade is (IMO) too problematic.

              ggrzybek Grzegorz Grzybek
              tcunning@redhat.com Thomas Cunningham
              Andrej Vano Andrej Vano
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Created:
                Updated:
                Resolved: