Uploaded image for project: 'Red Hat Fuse'
  1. Red Hat Fuse
  2. ENTESB-2178

Version with invalid name is created and stored to git

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • jboss-fuse-6.2
    • jboss-fuse-6.2
    • Fabric8 v1
    • None
    • % %
    • Hide

      1. 

       version-create 1.1.Foo


      2. Following exception is thrown: 

       Profile name '1.1.Foo' is invalid. Profile name must be: lower-case letters, numbers, and . _ or - characters

      3. After 

      version-list

      , same exception is thrown: 

       Profile name '1.1.Foo' is invalid. Profile name must be: lower-case letters, numbers, and . _ or - characters
      Show
      1. version-create 1.1.Foo 2. Following exception is thrown: Profile name '1.1.Foo' is invalid. Profile name must be: lower- case letters, numbers, and . _ or - characters 3. After version-list , same exception is thrown: Profile name '1.1.Foo' is invalid. Profile name must be: lower- case letters, numbers, and . _ or - characters

    Description

      Branch with invalid name is created in git even if following exception is thrown: 

       2014-11-11 09:51:15,800 | ERROR | l Console Thread | Console                          | ?                                   ? | 28 - org.apache.karaf.shell.console - 2.4.0.redhat-620046 | Exception caught while executing command
com.google.common.util.concurrent.UncheckedExecutionException: java.lang.IllegalArgumentException: Profile name '1.1.Foo' is invalid. Profile name must be: lower-case letters, numbers, and . _

      git branch

      in folder FUSE_DIR/data/git/local/: 

       1.0
  1.1.Foo
* master

      Looks like validation of branch name is performed after git push:

      2014-11-11 09:51:15,478 | INFO  | l Console Thread | ProfileServiceImpl               | ?                                   ? | 83 - io.fabric8.fabric-core - 1.2.0.redhat-046 | createVersion: 1.0 => 1.1.Foo
2014-11-11 09:51:15,633 | INFO  | l Console Thread | DefaultPullPushPolicy            | ?                                   ? | 85 - io.fabric8.fabric-git - 1.2.0.redhat-046 | Pushing last change to: http://dhcp-10-40-3-128.brq.redhat.com:8181/git/fabric/
2014-11-11 09:51:15,753 | INFO  | qtp312784494-139 | FabricGitServlet                 | ?                                   ? | 111 - io.fabric8.fabric-git-server - 1.2.0.redhat-046 | GitHttp service res=HTTP/1.1 200 
Expires: Fri, 01 Jan 1980 00:00:00 GMT
Pragma: no-cache
Cache-Control: no-cache, max-age=0, must-revalidate
Content-Type: application/x-git-receive-pack-result


2014-11-11 09:51:15,754 | INFO  | qtp312784494-139 | FabricGitServlet                 | ?                                   ? | 111 - io.fabric8.fabric-git-server - 1.2.0.redhat-046 | Remote git content updated: [Ref[refs/heads/1.0=021e08fd1558f290406b1b67e15ab9afa5dba399], Ref[refs/heads/1.1.Foo=7aa7f03e18fa249926700299f76fb7eda7f803d8], Ref[refs/heads/master=9fd223598d6e653a712d82157fd0c0f3c24320b7]]
2014-11-11 09:51:15,755 | INFO  | l Console Thread | DefaultPullPushPolicy            | ?                                   ? | 85 - io.fabric8.fabric-git - 1.2.0.redhat-046 | Push result: [accepted=3,rejected=0,error=null]
2014-11-11 09:51:15,800 | ERROR | l Console Thread | Console                          | ?                                   ? | 28 - org.apache.karaf.shell.console - 2.4.0.redhat-620046 | Exception caught while executing command

      Attachments

        Activity

          People

            pantinor@redhat.com Paolo Antinori
            mmelko@redhat.com Matej Melko
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: