Tried to rebuild crw-theia today to pull in latest branding PR fix.

      Got a big failure:

      Theia production-ready available in production.
      Removing intermediate container 324ca462b3e2
       ---> 88d92422bc22
      Step 31/51 : RUN if [ -z $GITHUB_TOKEN ]; then unset GITHUB_TOKEN; fi &&     cd plugins && ./foreach_yarn
       ---> Running in 83821da119de
      containers-plugin
      
      Running `yarn` on /home/theia-dev/theia-source-code/plugins/containers-plugin
      yarn install v1.17.3
      [1/4] Resolving packages...
      [2/4] Fetching packages...
      warning Pattern ["@eclipse-che/api@latest"] is trying to unpack in the same destination "/usr/local/share/.cache/yarn/v4/npm-@eclipse-che-api-7.3.0-364546157596936bb33cf39d61463e69973bf988/node_modules/@eclipse-che/api" as pattern ["@eclipse-che/api@^7.0.0-beta-4.0-80162ea6d2","@eclipse-che/api@^7.0.0-beta-4.0","@eclipse-che/api@^7.0.0-beta-4.0","@eclipse-che/api@^7.0.0-beta-4.0"]. This could result in non-deterministic behavior, skipping.
      info fsevents@1.2.9: The platform "linux" is incompatible with this module.
      info "fsevents@1.2.9" is an optional dependency and failed compatibility check. Excluding it from installation.
      warning @eclipse-che/theia-containers-plugin@0.0.2: The engine "theiaPlugin" appears to be invalid.
      warning @eclipse-che/theia-factory-plugin@0.0.1: The engine "theiaPlugin" appears to be invalid.
      warning @eclipse-che/ports-plugin@0.0.1: The engine "theiaPlugin" appears to be invalid.
      warning @eclipse-che/theia-ssh-plugin@0.0.1: The engine "theiaPlugin" appears to be invalid.
      warning task-plugin@0.0.1: The engine "theiaPlugin" appears to be invalid.
      warning @eclipse-che/welcome-plugin@0.0.1: The engine "theiaPlugin" appears to be invalid.
      warning monaco-languageclient@0.10.2: The engine "vscode" appears to be invalid.
      warning vscode-languageclient@5.3.0-next.9: The engine "vscode" appears to be invalid.
      [3/4] Linking dependencies...
      warning " > ts-jest@22.4.3" has incorrect peer dependency "typescript@2.x".
      warning " > tslint-language-service@0.9.9" has incorrect peer dependency "typescript@>= 2.3.1 < 3".
      warning "workspace-aggregator-01937cf4-c7a9-4d33-811d-79cbacd5f8fc > @eclipse-che/che-theia-hosted-plugin-manager-extension > @theia/plugin-ext > @theia/messages > react-perfect-scrollbar@1.5.3" has unmet peer dependency "react@>=16.3.3".
      warning "workspace-aggregator-01937cf4-c7a9-4d33-811d-79cbacd5f8fc > @eclipse-che/che-theia-hosted-plugin-manager-extension > @theia/plugin-ext > @theia/messages > react-perfect-scrollbar@1.5.3" has unmet peer dependency "react-dom@>=16.3.3".
      warning "workspace-aggregator-01937cf4-c7a9-4d33-811d-79cbacd5f8fc > @eclipse-che/che-theia-hosted-plugin-manager-extension > @theia/plugin-ext > @theia/scm > react-autosize-textarea@7.0.0" has unmet peer dependency "react@^0.14.0 || ^15.0.0 || ^16.0.0".
      warning "workspace-aggregator-01937cf4-c7a9-4d33-811d-79cbacd5f8fc > @eclipse-che/che-theia-hosted-plugin-manager-extension > @theia/plugin-ext > @theia/scm > react-autosize-textarea@7.0.0" has unmet peer dependency "react-dom@^0.14.0 || ^15.0.0 || ^16.0.0".
      warning Workspaces can only be enabled in private projects.
      [4/4] Building fresh packages...
      info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
      error /home/theia-dev/theia-source-code/che-theia/node_modules/nsfw: Command failed.
      Exit code: 1
      Command: node-gyp rebuild
      Arguments: 
      Directory: /home/theia-dev/theia-source-code/che-theia/node_modules/nsfw
      Output:
      gyp info it worked if it ends with ok
      gyp info using node-gyp@5.0.5
      gyp info using node@10.14.1 | linux | x64
      gyp info find Python using Python version 2.7.15 found at "/usr/bin/python2"
      gyp info spawn /usr/bin/python2
      gyp info spawn args [ '/home/theia-dev/theia-source-code/che-theia/node_modules/node-gyp/gyp/gyp_main.py',
      gyp info spawn args   'binding.gyp',
      gyp info spawn args   '-f',
      gyp info spawn args   'make',
      gyp info spawn args   '-I',
      gyp info spawn args   '/home/theia-dev/theia-source-code/che-theia/node_modules/nsfw/build/config.gypi',
      gyp info spawn args   '-I',
      gyp info spawn args   '/home/theia-dev/theia-source-code/che-theia/node_modules/node-gyp/addon.gypi',
      gyp info spawn args   '-I',
      gyp info spawn args   '/home/theia-dev/.cache/node-gyp/10.14.1/include/node/common.gypi',
      gyp info spawn args   '-Dlibrary=shared_library',
      gyp info spawn args   '-Dvisibility=default',
      gyp info spawn args   '-Dnode_root_dir=/home/theia-dev/.cache/node-gyp/10.14.1',
      gyp info spawn args   '-Dnode_gyp_dir=/home/theia-dev/theia-source-code/che-theia/node_modules/node-gyp',
      gyp info spawn args   '-Dnode_lib_file=/home/theia-dev/.cache/node-gyp/10.14.1/<(target_arch)/node.lib',
      gyp info spawn args   '-Dmodule_root_dir=/home/theia-dev/theia-source-code/che-theia/node_modules/nsfw',
      gyp info spawn args   '-Dnode_engine=v8',
      gyp info spawn args   '--depth=.',
      gyp info spawn args   '--no-parallel',
      gyp info spawn args   '--generator-output',
      gyp info spawn args   'build',
      gyp info spawn args   '-Goutput_dir=.' ]
      gyp info spawn make
      gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
      make: Entering directory '/home/theia-dev/theia-source-code/che-theia/node_modules/nsfw/build'
        CXX(target) Release/obj.target/nsfw/src/NSFW.o
      In file included from /home/theia-dev/.cache/node-gyp/10.14.1/include/node/node.h:63,
                       from ../../nan/nan.h:54,
                       from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      /home/theia-dev/.cache/node-gyp/10.14.1/include/node/v8.h:8548:3: error: unterminated comment
         /**
         ^
      In file included from /home/theia-dev/.cache/node-gyp/10.14.1/include/node/node.h:63,
                       from ../../nan/nan.h:54,
                       from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      /home/theia-dev/.cache/node-gyp/10.14.1/include/node/v8.h:15: error: unterminated #ifndef
       #ifndef INCLUDE_V8_H_
       
      In file included from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      ../../nan/nan.h:141: warning: "TYPE_CHECK" redefined
       #define TYPE_CHECK(T, S)                                                       \
       
      In file included from /home/theia-dev/.cache/node-gyp/10.14.1/include/node/node.h:63,
                       from ../../nan/nan.h:54,
                       from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      /home/theia-dev/.cache/node-gyp/10.14.1/include/node/v8.h:167: note: this is the location of the previous definition
       #define TYPE_CHECK(T, S)                                       \
       
      In file included from /home/theia-dev/.cache/node-gyp/10.14.1/include/node/node.h:64,
                       from ../../nan/nan.h:54,
                       from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      /home/theia-dev/.cache/node-gyp/10.14.1/include/node/v8-platform.h:16:1: error: expected unqualified-id before 'namespace'
       namespace v8 {
       ^~~~~~~~~
      In file included from ../../nan/nan.h:54,
                       from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      /home/theia-dev/.cache/node-gyp/10.14.1/include/node/node.h:104:1: error: expected unqualified-id before 'namespace'
       namespace v8 {
       ^~~~~~~~~
      /home/theia-dev/.cache/node-gyp/10.14.1/include/node/node.h:110:1: error: expected unqualified-id before 'namespace'
       namespace node {
       ^~~~~~~~~
      In file included from /usr/include/features.h:428,
                       from /usr/include/c++/8/x86_64-redhat-linux/bits/os_defines.h:39,
                       from /usr/include/c++/8/x86_64-redhat-linux/bits/c++config.h:2452,
                       from /usr/include/c++/8/string:38,
                       from ../src/../includes/Queue.h:4,
                       from ../src/../includes/NSFW.h:4,
                       from ../src/NSFW.cpp:1:
      /usr/include/assert.h:64:1: error: expected unqualified-id before string constant
       __BEGIN_DECLS
       ^~~~~~~~~~~~~
      In file included from ../../nan/nan.h:54,
                       from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      /home/theia-dev/.cache/node-gyp/10.14.1/include/node/node.h:204:1: error: expected unqualified-id before 'namespace'
       namespace node {
       ^~~~~~~~~
      In file included from ../../nan/nan.h:55,
                       from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      /home/theia-dev/.cache/node-gyp/10.14.1/include/node/node_buffer.h:28:1: error: expected unqualified-id before 'namespace'
       namespace node {
       ^~~~~~~~~
      In file included from /usr/include/features.h:428,
                       from /usr/include/c++/8/x86_64-redhat-linux/bits/os_defines.h:39,
                       from /usr/include/c++/8/x86_64-redhat-linux/bits/c++config.h:2452,
                       from /usr/include/c++/8/string:38,
                       from ../src/../includes/Queue.h:4,
                       from ../src/../includes/NSFW.h:4,
                       from ../src/NSFW.cpp:1:
      /usr/include/assert.h:64:1: error: expected unqualified-id before string constant
       __BEGIN_DECLS
       ^~~~~~~~~~~~~
      In file included from ../../nan/nan.h:56,
                       from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      /home/theia-dev/.cache/node-gyp/10.14.1/include/node/node_object_wrap.h:29:1: error: expected unqualified-id before 'namespace'
       namespace node {
       ^~~~~~~~~
      In file included from /usr/include/c++/8/bits/stl_algo.h:60,
                       from /usr/include/c++/8/algorithm:62,
                       from ../../nan/nan.h:57,
                       from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      /usr/include/c++/8/bits/algorithmfwd.h:42:1: error: expected unqualified-id before 'namespace'
       namespace std _GLIBCXX_VISIBILITY(default)
       ^~~~~~~~~
      In file included from /usr/include/c++/8/bits/stl_algo.h:66,
                       from /usr/include/c++/8/algorithm:62,
                       from ../../nan/nan.h:57,
                       from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      /usr/include/c++/8/bits/uniform_int_dist.h:37:1: error: expected unqualified-id before 'namespace'
       namespace std _GLIBCXX_VISIBILITY(default)
       ^~~~~~~~~
      In file included from /usr/include/c++/8/algorithm:62,
                       from ../../nan/nan.h:57,
                       from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      /usr/include/c++/8/bits/stl_algo.h:71:1: error: expected unqualified-id before 'namespace'
       namespace std _GLIBCXX_VISIBILITY(default)
       ^~~~~~~~~
      In file included from ../../nan/nan.h:58,
                       from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      /usr/include/c++/8/cstring:71:1: error: expected unqualified-id before 'namespace'
       namespace std _GLIBCXX_VISIBILITY(default)
       ^~~~~~~~~
      In file included from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      ../../nan/nan.h:95:1: error: expected unqualified-id before 'namespace'
       namespace Nan {
       ^~~~~~~~~
      In file included from ../../nan/nan_new.h:189,
                       from ../../nan/nan.h:288,
                       from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      ../../nan/nan_implementation_12_inl.h:358:28: error: expected '}' before end of line
       #pragma GCC diagnostic push
                                  ^
      In file included from /home/theia-dev/.cache/node-gyp/10.14.1/include/node/node.h:63,
                       from ../../nan/nan.h:54,
                       from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      /home/theia-dev/.cache/node-gyp/10.14.1/include/node/v8.h:8529:26: note: to match this '{'
       class V8_EXPORT TryCatch {
                                ^
      In file included from ../../nan/nan_new.h:189,
                       from ../../nan/nan.h:288,
                       from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      ../../nan/nan_implementation_12_inl.h:358:28: error: expected unqualified-id before end of line
       #pragma GCC diagnostic push
                                  ^
      ../../nan/nan_implementation_12_inl.h:358:28: error: expected '}' before end of line
      In file included from /home/theia-dev/.cache/node-gyp/10.14.1/include/node/node.h:63,
                       from ../../nan/nan.h:54,
                       from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      /home/theia-dev/.cache/node-gyp/10.14.1/include/node/v8.h:64:14: note: to match this '{'
       namespace v8 {
                    ^
      In file included from ../../nan/nan_new.h:189,
                       from ../../nan/nan.h:288,
                       from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      ../../nan/nan_implementation_12_inl.h:358:28: error: expected declaration before end of line
       #pragma GCC diagnostic push
                                  ^
      In file included from /home/theia-dev/.cache/node-gyp/10.14.1/include/node/node.h:63,
                       from ../../nan/nan.h:54,
                       from ../src/../includes/NSFW.h:6,
                       from ../src/NSFW.cpp:1:
      /home/theia-dev/.cache/node-gyp/10.14.1/include/node/v8.h:3489:19: warning: inline function 'void* v8::Object::GetAlignedPointerFromInternalField(int)' used but never defined
         V8_INLINE void* GetAlignedPointerFromInternalField(int index);
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      make: *** [nsfw.target.mk:118: Release/obj.target/nsfw/src/NSFW.o] Error 1
      make: Leaving directory '/home/theia-dev/theia-source-code/che-theia/node_modules/nsfw/build'
      gyp ERR! build error 
      gyp ERR! stack Error: `make` failed with exit code: 2
      gyp ERR! stack     at ChildProcess.onExit (/home/theia-dev/theia-source-code/che-theia/node_modules/node-gyp/lib/build.js:194:23)
      gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
      gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
      gyp ERR! System Linux 4.18.20-100.fc27.x86_64
      gyp ERR! command "/usr/bin/node" "/home/theia-dev/theia-source-code/che-theia/node_modules/.bin/node-gyp" "rebuild"
      gyp ERR! cwd /home/theia-dev/theia-source-code/che-theia/node_modules/nsfw
      gyp ERR! node -v v10.14.1
      gyp ERR! node-gyp -v v5.0.5
      gyp ERR! not ok
      

      Two questions:

      a) are we building from master or from 7.3.0 tag?
      b) is the problem the PR, or that che-theia master is broken, and we should us using a tag instead?

            nickboldt Nick Boldt
            nickboldt Nick Boldt
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: