Uploaded image for project: 'OpenShift Virtualization'
  1. OpenShift Virtualization
  2. CNV-41558

VMRestore webhook shouldn't check VM Running

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • None
    • 5
    • False
    • Hide

      None

      Show
      None
    • False
    • None
    • CNV-38613 - 2024 Code Quality
    • No
    • ---
    • ---
    • Storage Core Sprint 254

      In webhooks we want to prevent failing requests when they are raceful.

      Currently when creating the restore we check in the webhook that the VM is not Running by checking the vm.Spec.Running or if its run strategy is diffrerent then v1.RunStrategyHalted.

      We shouldn't fail the restore request in such case. Instead we should allow the object to be created and update its condition that the restore can't start until the VM is stopped.

            skagan@redhat.com Shelly Kagan
            skagan@redhat.com Shelly Kagan
            Ying Cui Ying Cui
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: