Uploaded image for project: 'Byteman'
  1. Byteman
  2. BYTEMAN-55

-s is really -b

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 1.2.0
    • 1.1.1
    • None
    • None

      The -s option in Submit doesn't really work - its always adding to the boot loader.

      Looking at HEAD here:

      http://anonsvn.jboss.org/repos/labs/labs/jbosstm/workspace/adinn/byteman/trunk/src/org/jboss/byteman/agent/submit/Submit.java

      and I see these, what appear to be cut-n-paste errors. Notice the "sys" options are still using BOOT and -b but they should be SYS and -s:

      } else if (args[startIdx].equals("-b"))

      { addBoot = true; startIdx ++; optionCount++; }

      else if (args[startIdx].equals("-b")) {
      addSys = true;
      startIdx ++;
      optionCount++;

      and

      if (addBoot) {
      stringBuffer.append("BOOT\n");
      for (int i = startIdx; i < maxIdx; i++)

      { String name = args[i]; stringBuffer.append(name); stringBuffer.append("\n"); }
      stringBuffer.append("ENDBOOT\n");
      } else if (addSys) {
      stringBuffer.append("BOOT\n");
      for (int i = startIdx; i < maxIdx; i++) { String name = args[i]; stringBuffer.append(name); stringBuffer.append("n"); }

      stringBuffer.append("ENDBOOT\n");
      } else {

            rhn-engineering-adinn Andrew Dinn
            jmazzitelli John Mazzitelli
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: