Loading...

Type: Task
Resolution: Done
Priority: Major
Fix Version/s: None
Affects Version/s: None
Component/s: None
Labels:
None

Git Pull Request:
https://github.com/aerogear/aerogear-simple-push-server/pull/17

Test will break with the latest version of Netty (currently 4.0.4.Final-SNAPSHOT). This task should fix these test failures:

websocketUnregister(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest)  Time elapsed: 0.052 sec  <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketUnregister(SimplePushSockJSServiceTest.java:211)

websocketHandleAcknowledgements(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest)  Time elapsed: 0.001 sec  <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketHandleAcknowledgements(SimplePushSockJSServiceTest.java:258)

websocketRegisterDuplicateChannelId(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest)  Time elapsed: 0.003 sec  <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketRegisterDuplicateChannelId(SimplePushSockJSServiceTest.java:199)

websocketHandleAcknowledgement(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest)  Time elapsed: 0.095 sec  <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketHandleAcknowledgement(SimplePushSockJSServiceTest.java:240)

websocketHello(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest)  Time elapsed: 0 sec  <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketHello(SimplePushSockJSServiceTest.java:175)

websocketUnregisterNonRegistered(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest)  Time elapsed: 0.138 sec  <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketUnregisterNonRegistered(SimplePushSockJSServiceTest.java:223)

websocketRegister(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest)  Time elapsed: 0.01 sec  <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketRegister(SimplePushSockJSServiceTest.java:186)

This was handled in the SockJS test by discarding empty responses for the websocket tests in question:

private Object readOutboundDiscardEmpty(final EmbeddedChannel ch) {
    final Object obj = ch.readOutbound();
    if (obj instanceof ByteBuf) {
        final ByteBuf buf = (ByteBuf) obj;
        if (buf.capacity() == 0) {
            ReferenceCountUtil.release(buf);
            return ch.readOutbound();
        }
    }
    return obj;
}

is blocked by

AEROGEAR-6276 Add SockJS support to Netty 5

Closed

Details

Description

Attachments

Issue Links

Activity

People

Dates