Uploaded image for project: 'JGroups'
  1. JGroups
  2. JGRP-2294

ForkProtocolStack ignores UnknownForkHandler for message batches

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 4.0.15
    • 4.0.13
    • None

      ForkProtocolStack.up(MessageBatch) discards messages if it doesn't the fork channel id isn't registered and they are part of a batch:

                      log.debug("fork-channel for id=%s not found; discarding message", fork_channel_id);
      

      I believe the check should also be enhanced to invoke the UnknownForkHandler if the ForkChannel is registered but is not yet connected. Otherwise messages that arrive after the ForkChannel registers itself in the constructor and before our JGroupsTransport registers itself as an UpHandler with the ForkChannel will also be discarded.

      I misread the ForkChannel code, the registratioon in the ForkProtocolStack only happens in ForkChannel.connect().

            rhn-engineering-bban Bela Ban
            dberinde@redhat.com Dan Berindei (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: