[TEIID-5005] Boolean expression is incorrectly rewritten in WHERE condition and causes errors on PG Created: 25/Jul/17  Updated: 25/Jul/17  Resolved: 25/Jul/17

Status: Resolved
Project: Teiid
Component/s: Query Engine
Affects Version/s: 9.3.1
Fix Version/s: 10.0, 9.2.5, 9.3.2

Type: Bug Priority: Blocker
Reporter: dalex dalex Assignee: Steven Hawkins
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

teiid-9.3.1 on WildFly Full 10.0.0.Final (WildFly Core 2.0.10.Final)


Steps to Reproduce:

1. In PostgreSQL create the test_bool_exps table by the following script:

CREATE TABLE public.test_bool_exps
(
  a integer,
  b boolean
);
INSERT INTO public.test_bool_exps(a, b) VALUES (1, true);

2. Add PostgreSQL database configuration in standalone-teiid.xml:

                <datasource jndi-name="java:/test_pg" pool-name="test_pg" enabled="true" use-java-context="true">
                    <connection-url>jdbc:postgresql://localhost:5432/test?charSet=utf8</connection-url>
                    <driver-class>org.postgresql.Driver</driver-class>
                    <driver>org.postgresql</driver>
                    <pool>
                        <min-pool-size>2</min-pool-size>
                        <max-pool-size>70</max-pool-size>
                        <prefill>false</prefill>
                        <use-strict-min>false</use-strict-min>
                        <flush-strategy>FailingConnectionOnly</flush-strategy>
                    </pool>
                    <security>
                        <user-name>postgres</user-name>
                        <password>xxxxxx</password>
                    </security>
                    <validation>
                        <check-valid-connection-sql>select 0</check-valid-connection-sql>
                    </validation>
                    <timeout>
                        <blocking-timeout-millis>120000</blocking-timeout-millis>
                        <idle-timeout-minutes>5</idle-timeout-minutes>
                    </timeout>
                </datasource>

3. Add in test-vdb.xml test_pg model configured in previous step as datasource:

    <model name="test_pg">
        <property name="importer.useFullSchemaName" value="false"/>
        <property name="importer.tableTypes" value="TABLE,VIEW"/>
        <property name="importer.importKeys" value="false"/>
        <source name="test_pg" translator-name="postgresql" connection-jndi-name="java:/test_pg"/>
    </model>

4. run the following query:

select * from test_pg.test_bool_exps where ((b=true) and (a=1)) = true ;;


 Description   

when running the following query on PG:

select * from test_pg.test_bool_exps where ((b=true) and (a=1)) = true ;;

teiid returns the following error:

2017-07-25 13:19:10,211 WARN  [org.teiid.CONNECTOR] (Worker5_QueryProcessorQueue329) o4ihy1GzEdYV Connector worker process failed for atomic-request=o4ihy1GzEdYV.89.0.71: org.teiid.t
ranslator.jdbc.JDBCExecutionException: 0 TEIID11008:TEIID11004 Error executing statement(s): [Prepared Values: [] SQL: SELECT g_0."a" AS c_0, g_0."b" AS c_1 FROM "public"."test_bool_
exps" AS g_0 WHERE g_0."b" = TRUE AND g_0."a" = 1 = TRUE LIMIT 100]
        at org.teiid.translator.jdbc.JDBCQueryExecution.execute(JDBCQueryExecution.java:131)
        at org.teiid.dqp.internal.datamgr.ConnectorWorkItem.execute(ConnectorWorkItem.java:365)
        at sun.reflect.GeneratedMethodAccessor89.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.teiid.dqp.internal.datamgr.ConnectorManager$1.invoke(ConnectorManager.java:220)
        at com.sun.proxy.$Proxy28.execute(Unknown Source)
        at org.teiid.dqp.internal.process.DataTierTupleSource.getResults(DataTierTupleSource.java:306)
        at org.teiid.dqp.internal.process.DataTierTupleSource$1.call(DataTierTupleSource.java:112)
        at org.teiid.dqp.internal.process.DataTierTupleSource$1.call(DataTierTupleSource.java:108)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at org.teiid.dqp.internal.process.FutureWork.run(FutureWork.java:65)
        at org.teiid.dqp.internal.process.DQPWorkContext.runInContext(DQPWorkContext.java:284)
        at org.teiid.dqp.internal.process.ThreadReuseExecutor$RunnableWrapper.run(ThreadReuseExecutor.java:119)
        at org.teiid.dqp.internal.process.ThreadReuseExecutor$3.run(ThreadReuseExecutor.java:210)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)

though the same query on MySQL, MSSQL and Oracle works correctly.



 Comments   
Comment by Steven Hawkins [ 25/Jul/17 ]

The fix for TEIID-4877 was too narrow. We need to nest more expression types in parens to satisfy the pg parser.

Comment by Steven Hawkins [ 25/Jul/17 ]

Expanded the previous fix to all conditions.

Comment by dalex dalex [ 25/Jul/17 ]

Steven Hawkins great! thx a lot for the quick fix.

Generated at Sat Oct 20 12:13:12 EDT 2018 using Jira 7.12.1#712002-sha1:609a50578ba6bc73dbf8b05dddd7c04a04b6807c.