March 4 IRC records from teiiddesigner: (02:56:11 PM) tejones: blafond: danflo: vhalbert24: Regarding https://issues.jboss.org/browse/TEIIDDES-640... (02:56:13 PM) jbossbot: jira [TEIIDDES-640] Exporting a relational to ddl, and turned off the comments option did not eliminate the comments from the ddl file. [Open (Unresolved) Bug, Minor, Ted Jones] https://issues.jboss.org/browse/TEIIDDES-640 (02:57:17 PM) tejones: blafond: danflo: vhalbert24: I am leaning towards option #2 that I have described in Jira comment... any dissenting opinions? (02:59:07 PM) danflo: tejones: #2 makes sense to me. (03:00:12 PM) danflo: tejones: header comments will always be generated then? (03:00:43 PM) vhalbert24: tejones, that's a litte confusing (03:01:05 PM) tejones: danflo: Yes... like I say in the Jira... "Generate Comments = true/false" is actually a comment, so it makes sense to show it (03:01:46 PM) vhalbert24: tejones, option 2, when option is chose to turn off comments, don't put any comments in the file (03:02:31 PM) vhalbert24: #2 is just the option, that's shouldn't appear in the file (03:03:40 PM) tejones: vhalbert24: it sounds like you may be leaning more towards option #1? (03:04:10 PM) vhalbert24: tejones, #3 (03:04:48 PM) vhalbert24: when someone want's their ddl stripped clean, this is the assumed action (03:05:01 PM) tejones: vhalbert24: Ah... and just remove the "Generate Comments = true/false" comment (03:05:15 PM) vhalbert24: tejones, all comments (03:05:53 PM) tejones: vhalbert24: What I mean is "Generate Comments = true/false" is a comment, it will never show up when "Generate Comments = false" (03:06:09 PM) tejones: vhalbert24: so it should just be removed (03:06:15 PM) vhalbert24: tejones, yes (03:06:24 PM) tejones: danflo: What say you? (03:06:27 PM) vhalbert24: tejones, its not useful in the ddl (03:06:49 PM) vhalbert24: tejones, and its not really applicable to the content (03:06:56 PM) tejones: pnittel: Any thoughts on this? ^^ (03:07:30 PM) danflo: tejones: sorry chatting with Ramesh on other window. need to catch up. (03:11:24 PM) danflo: tejones, vhalbert24: "Generate Comments" comment doesn't seem to add much value (03:12:19 PM) pnittel: tejones: vhalbert24: danflo: I'm inclined to say that the user should be able to declare whether or not they want comments built from descriptions in the models. If they say NO, then there should be no comments anywhere in the file. The "Generate comments" comment seems Monty Python-ish. ;-) (03:16:44 PM) tejones: pnittel: danflo: vhalbert24: My crystal ball says if we remove ALL comments users are going to want only entity description values and no header comments or vice-versa, but I am okay if that is the consensus opinion. :-) (03:18:56 PM) vhalbert24: tejones, IMO, when someone request that comments be removed, they're getting rid of that syntax, they don't want to deal with it (03:26:04 PM) danflo: pnittel, vhalbert24, tejones: it would be nice to have the flexibility to include/exclude each type of comments individually but if that is not something a user would want it seems silly to implement. I don't know what the typical user would want so I defer to you guys. Ted you could keep the idea of 2 types of comments in the code and just not expose that to the user. Then if the idea ever comes back it should be easy to bring back. (03:29:23 PM) tejones: danflo: vhalbert24: pnittel: fair enough... de-selecting "Generate Comments" will remove header comments and entity descriptions, but I will leave hooks in case we need to differentiate in the future. Thanks for the insightful feedback. :-) On another note, I added a description to a table column and it did not show up in my DDL. :-/ (03:33:05 PM) danflo: tejones: Seems like I've tried that also unsuccessfully. I think comments are only supported at the table-level but blafond would have to verify. And not sure why if it is so. (03:33:54 PM) tejones: danflo: Ah... that would 'splain it. Thanks March 7 IRC records from teiiddesigner: (08:14:41 AM) tejones: blafond: danflo: vhalbert: pnittel: re: https://issues.jboss.org/browse/TEIIDDES-640 a.k.a. "the Jira upon which no one could agree" and "notorious J-I-R-A"... (08:14:43 AM) jbossbot: jira [TEIIDDES-640] Exporting a relational to ddl, and turned off the comments option did not eliminate the comments from the ddl file. [Open (Unresolved) Bug, Minor, Ted Jones] https://issues.jboss.org/browse/TEIIDDES-640 (08:15:38 AM) tejones: blafond: danflo: vhalbert: pnittel: please see the comment Barry added. It throws a wrench into what we decided Friday. (08:17:28 AM) tejones: blafond: danflo: vhalbert: pnittel: also, there are more comments throughout the DDL, depending on what other options you choose for generation (DROP TABLE, for example has comments added just before the drop statements) (08:19:25 AM) pnittel left the room (quit: Quit: Be right back). (08:20:02 AM) blafond: danflo: vhalbert: tejones: As I said in my jira "comment" the check- box is supposed to let users turn Model Object annotations (i.e. descriptions) for tables and columns be added to their DDL. However that's worded, that is the mechanics of what's supposed to happen. (08:20:45 AM) tejones: blafond: Only applies to tables though, right? Not seeing them for columns/ (08:21:11 AM) blafond: danflo: vhalbert: tejones: What we call our "Header" or additional DDL info is something else. So if we keep the feature, then they UI should use "COMMENT ON" in the UI label or something. (08:21:22 AM) pnittel [~pnittel@nat/redhat/x-kopkoucjlvvhwmrv] entered the room. (08:21:24 AM) blafond: The XSLT makes provisions for Column level descriptions (08:22:59 AM) tejones: blafond: So would you prefer another option for the Header comments? (08:23:26 AM) tejones: blafond: something like Option 1? (08:23:40 AM) blafond: tejones: Yes I would. Maybe "Include db-specific DDL header"? (08:24:24 AM) tejones: blafond: There are other comments dispersed throughout the DDL as well (08:25:04 AM) maxandersen left the room (quit: Quit: Leaving.). (08:25:12 AM) blafond: tejones: Then "Include DB-specific export information" (08:26:10 AM) tejones: blafond: Here's the comment for DROP TABLE DDL - "-- Drop the objects in the schema" (08:26:48 AM) tejones: blafond: That's pretty general, not really db-specific (08:26:49 AM) blafond: tejones: Breaking out "Convert Table descriptions to COMMENT ON statements" and "Convert Column descriptions to COMMENT ON statements" or create a Group panel containing 2 check-boxes (08:28:09 AM) tejones: blafond: I like that approach (08:28:14 AM) blafond: tejones: It seems to me that "COMMENT ON XXXXX" statements in the DDL are vastly different than DDL comments. It's just a matter of how we describe/label them in the UI so the user knows which is which. (08:28:28 AM) tejones: blafond: agreed (08:28:56 AM) blafond: tejones: Why don't you throw something together and add the screen caps to the JIRA and we can all throw darts or roses at it ? :) (08:29:12 AM) tejones: blafond: Sounds like a plan