(7:55:25 AM) blafond: danflo: jfd: tejones: pnittel: for 7.3, TEIIDDES-806 will be the primary feature-change. With the help from Hawkman, I've got the basics working and a design implemented. Can one or more of you check it out, and ride shot-gun so I get another "uers's perspective" and a set of eyes on it? I've included a screen pic and some basic info. Feel free to comment :) (7:55:26 AM) jbossbot: jira [TEIIDDES-806] Provide UI changes required for changes to behavior of Update queries in Teiid [Open, Blocker, Barry LaFond] https://issues.jboss.org/browse/TEIIDDES-806 (8:00:59 AM) pnittel: blafond: Sorry, was performing a maintenance function: brushing teeth. :-) (8:01:23 AM) blafond: are you running them past QE? (8:01:41 AM) pnittel: blafond: Only if we video conference. (8:04:11 AM) tejones: blafond: syre thing (8:04:15 AM) tejones: sure (8:04:31 AM) blafond: more the merrier... (8:08:13 AM) vhalbert [~Van@nat/redhat/x-cxprzntdogobqnzc] entered the room. (8:12:32 AM) pnittel: blafond: In 806's screenshot, was the mouse hovering over the INSERT tab for that tool-tip to appear? (8:12:53 AM) blafond: pnittel: yes. (8:13:07 AM) danflo is now known as danflo|brb (8:13:52 AM) pnittel: blafond: Cool. I like it. The fact that we're letting the user know something before they go down a rat hole is very high on the usability scale! (8:14:48 AM) blafond: The premise of the feature change was to allow more complex SELECT SQL and still perform "Default" Update procedures ( or for each row). AND we don't generate default SQL anymore. it's done by Teiid at runtime (8:15:35 AM) blafond: But the SELECT SQL needs to get "validated" to determine if Teiid Query engine can generate a DEFAULT. So Designer needs to provide UI Feedback on the results of that "validation" (8:16:21 AM) pnittel: blafond: I'm looking forward to seeing the complete package (Teiid and Designer). We'll have to augment our tests a bit. (8:16:27 AM) blafond: the "not allowed" ICON indicates that the Validation determined the user CANNOT Insert/Update/Delete (8:18:47 AM) blafond: Yes. I don't have much to test with yet in terms of queries. We'll need them soon. If you use a "non-updateable" view as a source table, it'll fail validation for updates. a "SELECT 1" statement will fail also, but those dont' help much (8:27:59 AM) jfd: blafond, where is "Use Default" selected/deselected? (8:29:00 AM) blafond: On the three extra tabs, Insert Update Delete. There used to be an "Enable" check-box too, but that made no sense anymore since we're determing it on the fly (8:45:38 AM) jfd: blafond, confused a bit by the comment to the pic. The pic demonstrates the case where the select is valid, but the update/insert cannot be created by Teiid? (8:46:06 AM) blafond: yes. and yes (8:48:30 AM) blafond: We've always used a standard query Validator. Now there's an "UpdateValidator" class that validates the SELECT SQL again, but from an update perspective. (8:49:41 AM) blafond: Each type (Insert/Update/Delete) can now use "Default" or INHERENT option or "INSTEAD_OF" (new trigger action option) which we haven't accounted for yet (8:49:45 AM) jfd: blafond, OK, thx. Are you going to visually differentiate a 'defaulted' update/insert tab from a user defined one? (8:49:53 AM) danflo: blafond: will the "not allowed" tabs be disabled? Might not need the icon then. (8:50:28 AM) blafond: oh. hadn't thought of that. Suggestions? (INSERT (D), UPDATE(D), DELETE)? (8:52:09 AM) blafond: Well a user can still go to a "not allowed" tab, change the USE DEFAULT option and type away (8:52:20 AM) blafond: USE DEFAULT to FALSE... (8:53:27 AM) danflo: guess I thought the icon meant that that an available operation (i.e., no deletes allowed). Don't think it is a good icon to show that the default is being used. (8:55:36 AM) blafond: So an "Error" icon then? (8:56:23 AM) blafond: So a user may or may not care about all Insert/Update/Delete lets call it DUI today... (8:57:23 AM) blafond: So if a SELECT does NOT support INSERT, for instance, it results in a INSERT validation error, but its not really an error. User can still run SELECT, DELETE and UPDATE queries. (9:02:28 AM) danflo: Sorry I must not be awake yet so getting a bit confused. I'll try again… If an operation is not supported seems like the tab would be disabled and/or have that red x. If an operation is supported and the user has chosen to use the default, not sure any special decorations are needed on the tab. (9:03:44 AM) blafond: I guess disabled tab is OK as long as a user can select the tab and uncheck the "Use Default" option (9:03:59 AM) jfd: blafond, I would prefer to limit the red to real errors, or not use it at all since we are putting things in the problems view. (9:04:44 AM) jfd: blafond, agree with your last comment (9:04:56 AM) blafond: and an FYI, when we index these transformations, a "Use Default == TRUE" will NOT add the index for te particular DUI SQL. If USE DEFAULT == FALSE and SQL is entered in the DUI tab, it'll be indexed. (9:06:46 AM) blafond: So when a user choosed "Use Default", they are expecting TEIID Query engine to "figure it out". We're just trying to help them determine the "figure it out" at design time. This Valdiation is an AID, so to speak. (9:08:58 AM) danflo: blafond, jfd: I guess I'm still not making any sense … don't understand, based on my previous comment, why a tab would be disabled if the user has selected the default be used. A tab would only be disabled when an operation is not available like in your "if a SELECT does NOT support INSERT" example above the insert tab would be disabled. I'm going back to work on 808 now. (9:10:32 AM) jfd: I think the text area should be disabled is the user selects 'use default' (9:10:59 AM) blafond: jfd: already is. (9:12:18 AM) blafond: We're talking visual cue's here and a small amount of real estate and a complex "new concept". This is all good feeback/suggestions.... (9:13:35 AM) jfd: blafond, works for me. in the case where DUI is not allowed by the transformation source, I would favor a grey version of the icon you have now (circle with slash) (9:14:26 AM) jfd: blafond, I should say one or more of the DUI is not allowed. (9:14:56 AM) jfd: red says 'broken' to me (9:18:00 AM) blafond: I'll go for gray or "grey" and check out disable tab... and get back to ya all